Fix stan errors

Author: ADmad

phpstan.neon

@@ -1,9 +1,12 @@
 parameters:
 	level: 7
-	checkMissingIterableValueType: false
-	checkGenericClassInNonGenericObjectType: false
 	treatPhpDocTypesAsCertain: false
 	bootstrapFiles:
 		- tests/bootstrap.php
 	paths:
 		- src
+	ignoreErrors:
+		-
+			identifier: missingType.iterableValue
+		-
+			identifier: missingType.generics

psalm.xml

@@ -19,5 +19,6 @@
     <issueHandlers>
         <PropertyNotSetInConstructor errorLevel="info" />
         <MissingConstructor errorLevel="info" />
+        <RiskyTruthyFalsyComparison errorLevel="info" />
     </issueHandlers>
 </psalm>

src/Command/I18nExtractCommand.php

@@ -63,15 +63,15 @@ public static function defaultName(): string
     public function execute(Arguments $args, ConsoleIo $io): ?int
     {
         $plugin = '';
-        if ($args->getOption('exclude')) {
+        if ($args->hasOption('exclude')) {
             $this->_exclude = explode(',', (string)$args->getOption('exclude'));
         }
-        if ($args->getOption('files')) {
+        if ($args->hasOption('files')) {
             $this->_files = explode(',', (string)$args->getOption('files'));
         }
-        if ($args->getOption('paths')) {
+        if ($args->hasOption('paths')) {
             $this->_paths = explode(',', (string)$args->getOption('paths'));
-        } elseif ($args->getOption('plugin')) {
+        } elseif ($args->hasOption('plugin')) {
             $plugin = Inflector::camelize((string)$args->getOption('plugin'));
             $this->_paths = [Plugin::classPath($plugin), Plugin::templatePath($plugin)];
         } else {
@@ -90,6 +90,10 @@ public function execute(Arguments $args, ConsoleIo $io): ?int
         }
 
         if ($args->hasOption('exclude-plugins') && $this->_isExtractingApp()) {
+            /**
+             * @phpstan-ignore-next-line
+             * @psalm-suppress PropertyTypeCoercion
+             */
             $this->_exclude = array_merge($this->_exclude, App::path('plugins'));
         }
 
@@ -206,7 +210,7 @@ protected function _saveMessages(Arguments $args, ConsoleIo $io): void
         });
 
         $domains = null;
-        if ($args->getOption('domains')) {
+        if ($args->hasOption('domains')) {
             $domains = explode(',', (string)$args->getOption('domains'));
         }
 
@@ -222,7 +226,7 @@ protected function _saveMessages(Arguments $args, ConsoleIo $io): void
             foreach ($translations as $msgid => $contexts) {
                 foreach ($contexts as $context => $details) {
                     $references = null;
-                    if (!$args->getOption('no-location')) {
+                    if (!(bool)$args->getOption('no-location')) {
                         $files = $details['references'];
                         $occurrences = [];
                         foreach ($files as $file => $lines) {

src/Middleware/I18nMiddleware.php

@@ -138,7 +138,7 @@ public function ignoreRequestCallback(Closure $callback)
      */
     public function detectLanguage(ServerRequest $request, ?string $default = null): string
     {
-        if (empty($default)) {
+        if (!$default) {
             $lang = $this->_config['defaultLanguage'];
         } else {
             $lang = $default;