Skip to content

Commit 2131ddb

Browse files
committed
chore: update to node 18
Local development now uses node 18, and we test 14 through 18 in CI
1 parent 798827f commit 2131ddb

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
strategy:
77
matrix:
88
arango-image: ['arangodb:3.6', 'arangodb:3.7', 'arangodb:3.8', 'arangodb:3.9']
9-
node-version: [14.x, 16.x]
9+
node-version: [14.x, 16.x, 18.x]
1010
steps:
1111
- uses: actions/checkout@v2
1212
- name: Use Node.js ${{ matrix.node-version }}
@@ -38,7 +38,7 @@ jobs:
3838
- uses: actions/checkout@v2
3939
- uses: actions/setup-node@v1
4040
with:
41-
node-version: 16
41+
node-version: 18
4242
registry-url: https://registry.npmjs.org/
4343
- run: npm ci
4444
- run: npm publish --tag next

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16
1+
18

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@types/deep-equal-in-any-order": "^1.0.1",
4848
"@types/lodash": "^4.14.184",
4949
"@types/mocha": "^9.1.1",
50-
"@types/node": "^16.11.43",
50+
"@types/node": "^18.11.18",
5151
"@types/pluralize": "0.0.29",
5252
"@types/uuid": "^8.3.4",
5353
"ajv-cli": "^5.0.0",

spec/regression/initialization.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import stripJsonComments from 'strip-json-comments';
66
import { ArangoDBConfig } from '../../src/database/arangodb';
77

88
const DATABASE_NAME = 'cruddl-test-temp';
9-
const DATABASE_URL = 'http://root:@localhost:8529';
9+
// arangodb only listens on ipv4, but localhost may resolve to ::1, so explicitly state 127.0.0.1
10+
const DATABASE_URL = 'http://root:@127.0.0.1:8529';
1011

1112
export async function createTempDatabase(): Promise<ArangoDBConfig> {
1213
const systemDatabase = new Database({

0 commit comments

Comments
 (0)