fix: fix @defaultValue on Int and Float fields storing strings instead of numbers

If you used `@defaultValue` with an `Int` or `Float` value, the value
was stored as a serialized string instead of the numeric value. This
made no difference for retrieving the value because strings are
implicitly converted to strings there, but it had an effect on sorting
and filtering.

Author: Yogu

spec/regression/logistics/tests/default-value.graphql

@@ -41,3 +41,45 @@ mutation createNewWithSomeOtherValuesOverwritten {
         defaultValueEnum
     }
 }
+
+# just querying (like checkCreatedByInit) does would automatically type-convert strings to numbers
+# when required. We had a bug where @defaultValue on Int and Float stored Strings. Filtering does
+# not automatically type-convert, so we can use this to verify that the types are correct
+# doing this after createNewWithSomeOtherValuesOverwritten to test that that one won't be returned
+query checkFiltersByInit {
+    allDeliveries(
+        filter: {
+            destination: {
+                street: "Hauptstraße"
+                city: "Stuttgart"
+                zipCode: "70xxx"
+                country: { isoCode: "DE" }
+            }
+            defaultValueString: "foo"
+            defaultValueString2: "bar"
+            defaultValueInt: 42
+            defaultValueTrue: true
+            defaultValueFalse: false
+            defaultValueFloat: 3.14
+            defaultValueEnum: Bar
+        }
+        orderBy: deliveryNumber_ASC
+    ) {
+        deliveryNumber
+        destination {
+            street
+            city
+            zipCode
+            country {
+                isoCode
+            }
+        }
+        defaultValueString
+        defaultValueString2
+        defaultValueInt
+        defaultValueTrue
+        defaultValueFalse
+        defaultValueFloat
+        defaultValueEnum
+    }
+}

spec/regression/logistics/tests/default-value.result.json

@@ -80,5 +80,65 @@
         "defaultValueEnum": "Bar"
       }
     }
+  },
+  "checkFiltersByInit": {
+    "data": {
+      "allDeliveries": [
+        {
+          "deliveryNumber": "1000173",
+          "destination": {
+            "street": "Hauptstraße",
+            "city": "Stuttgart",
+            "zipCode": "70xxx",
+            "country": {
+              "isoCode": "DE"
+            }
+          },
+          "defaultValueString": "foo",
+          "defaultValueString2": "bar",
+          "defaultValueInt": 42,
+          "defaultValueTrue": true,
+          "defaultValueFalse": false,
+          "defaultValueFloat": 3.14,
+          "defaultValueEnum": "Bar"
+        },
+        {
+          "deliveryNumber": "1000521",
+          "destination": {
+            "street": "Hauptstraße",
+            "city": "Stuttgart",
+            "zipCode": "70xxx",
+            "country": {
+              "isoCode": "DE"
+            }
+          },
+          "defaultValueString": "foo",
+          "defaultValueString2": "bar",
+          "defaultValueInt": 42,
+          "defaultValueTrue": true,
+          "defaultValueFalse": false,
+          "defaultValueFloat": 3.14,
+          "defaultValueEnum": "Bar"
+        },
+        {
+          "deliveryNumber": "1000522",
+          "destination": {
+            "street": "Hauptstraße",
+            "city": "Stuttgart",
+            "zipCode": "70xxx",
+            "country": {
+              "isoCode": "DE"
+            }
+          },
+          "defaultValueString": "foo",
+          "defaultValueString2": "bar",
+          "defaultValueInt": 42,
+          "defaultValueTrue": true,
+          "defaultValueFalse": false,
+          "defaultValueFloat": 3.14,
+          "defaultValueEnum": "Bar"
+        }
+      ]
+    }
   }
-}
+}

src/graphql/value-from-ast.ts

@@ -9,11 +9,15 @@ import { PlainObject } from '../utils/utils';
 export function getValueFromAST(valueNode: ValueNode): any {
     switch (valueNode.kind) {
         case Kind.STRING:
-        case Kind.INT:
-        case Kind.FLOAT:
         case Kind.BOOLEAN:
         case Kind.ENUM:
             return valueNode.value;
+        case Kind.INT:
+            // this is the logic in GraphQLInt.prototype.parseInt
+            return parseInt(valueNode.value, 10);
+        case Kind.FLOAT:
+            // this is the logic in GraphQLFloat.prototype.parseFloat
+            return parseFloat(valueNode.value);
         case Kind.LIST:
             return [...valueNode.values.map((value) => getValueFromAST(value))];
         case Kind.OBJECT: