Skip to content

Commit 5e39435

Browse files
committed
ci: test with ArangoDB 3.12
There is a breaking change in ArangoDB 3.12 that the default locale changes from en_US to en_US_POSIX. cruddl has some logic that relies on the order of values according to the non-POSIX locale. Therefore, we need to set it using LOCALE in the tests. Consider this: for a in ["Scal", "PART", "part"] sort a return a cruddl assumes it to be [ "PART", "part", "Scal" ] but in 3.12 without locale set (so en_US_POSIX) is used, it would be: [ "PART", "Scal", "part" ]
1 parent 86ce3ca commit 5e39435

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@ jobs:
55
runs-on: ubuntu-latest
66
strategy:
77
matrix:
8-
arango-image: ['arangodb:3.8', 'arangodb:3.9', 'arangodb:3.10', 'arangodb:3.11']
8+
arango-image:
9+
[
10+
"arangodb:3.8",
11+
"arangodb:3.9",
12+
"arangodb:3.10",
13+
"arangodb:3.11",
14+
"arangodb:3.12",
15+
]
916
node-version: [14.x, 16.x, 18.x]
1017
steps:
1118
- uses: actions/checkout@v2
@@ -14,7 +21,7 @@ jobs:
1421
with:
1522
node-version: ${{ matrix.node-version }}
1623
- run:
17-
docker run --name arangodb -p 127.0.0.1:8529:8529 -d -e ARANGO_NO_AUTH=1 ${{
24+
docker run --name arangodb -p 127.0.0.1:8529:8529 -d -e ARANGO_NO_AUTH=1 -e LANG=en_US ${{
1825
matrix.arango-image }}
1926
- run: timeout 10 docker logs --follow arangodb || true # wait until arangodb is started
2027
- run: curl -L http://localhost:8529/_api/version

README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,13 @@ When done, stop the instance with `npm run stop_arangodb`
136136

137137
cruddl currently supports the following versions of ArangoDB:
138138

139-
- 3.8
140-
- 3.9
141-
- 3.10
142-
- 3.11
139+
- 3.8
140+
- 3.9
141+
- 3.10
142+
- 3.11
143+
- 3.12
144+
145+
Starting with ArangoDB 3.12, the default locale for new databases has been changed from `en_US` to
146+
`en_US_POSIX`. cruddl does not support `en_US_POSIX` at the moment, so you need to change the locale
147+
to `en_US`. See
148+
[the ArangoDB announcemenent](https://docs.arangodb.com/3.12/release-notes/version-3.12/incompatible-changes-in-3-12/#default-server-language-changed).

0 commit comments

Comments
 (0)