Adapt genai and client tests to new changes

Author: edkaya

client/src/components/__tests__/MessageItem.test.tsx

@@ -34,15 +34,18 @@ describe("MessageItem Component", () => {
     render(<MessageItem message={mockBotMessage} />);
 
     expect(screen.getByText("AI Assistant")).toBeInTheDocument();
-    expect(screen.getByText("I'm doing well, thank you!")).toBeInTheDocument();
-    expect(screen.getByText("How can I help you today?")).toBeInTheDocument();
+    expect(screen.getByText(/I'm doing well, thank you!/)).toBeInTheDocument();
+    expect(screen.getByText(/How can I help you today?/)).toBeInTheDocument();
     expect(screen.getByText(/ago/)).toBeInTheDocument();
   });
 
   it("handles multi-line content with proper paragraph breaks", () => {
     render(<MessageItem message={mockBotMessage} />);
 
-    const paragraphs = screen.getAllByText(/I'm doing well|How can I help/);
-    expect(paragraphs).toHaveLength(2);
+    // With react-markdown, newlines create line breaks within a single paragraph
+    const paragraph = screen.getByText(/I'm doing well, thank you!/);
+    expect(paragraph).toBeInTheDocument();
+    expect(paragraph.textContent).toContain("I'm doing well, thank you!");
+    expect(paragraph.textContent).toContain("How can I help you today?");
   });
 });

genai/tests/integration/generation_test.py

@@ -6,7 +6,10 @@
 
 
 @patch("rag.llm.chat_model.ChatModel.invoke")
-@patch("routes.routes.qdrant.client.collection_exists", return_value=False)
+@patch(
+    "service.qdrant_service.qdrant.client.collection_exists",
+    return_value=False
+    )
 def test_generate_endpoint_success(_mock_exists, mock_invoke):
     mock_response = MagicMock()
     mock_response.content = "This is a test response"
@@ -31,7 +34,10 @@ def test_generate_endpoint_success(_mock_exists, mock_invoke):
 
 
 @patch("rag.llm.chat_model.ChatModel.invoke")
-@patch("routes.routes.qdrant.client.collection_exists", return_value=False)
+@patch(
+    "service.qdrant_service.qdrant.client.collection_exists",
+    return_value=False
+    )
 def test_generate_endpoint_empty_messages(_mock_exists, mock_invoke):
 
     mock_response = MagicMock()

genai/tests/integration/upload_test.py

@@ -7,9 +7,12 @@
 client = TestClient(app)
 
 
-@patch("routes.routes.qdrant.client.collection_exists", return_value=False)
-@patch("routes.routes.qdrant.create_and_get_vector_storage")
-@patch("routes.routes.IngestionPipeline")
+@patch(
+    "service.qdrant_service.qdrant.client.collection_exists",
+    return_value=False
+    )
+@patch("service.qdrant_service.qdrant.create_and_get_vector_storage")
+@patch("service.qdrant_service.IngestionPipeline")
 def test_upload_file_success(
         mock_pipeline_class,
         _mock_vector_store,
@@ -62,8 +65,14 @@ def test_upload_file_invalid_type():
     app.dependency_overrides.clear()
 
 
-@patch("routes.routes.qdrant.client.collection_exists", return_value=True)
-@patch("routes.routes.qdrant.collection_contains_file", return_value=True)
+@patch(
+    "service.qdrant_service.qdrant.client.collection_exists",
+    return_value=True
+    )
+@patch(
+    "service.qdrant_service.qdrant.collection_contains_file",
+    return_value=True
+    )
 def test_upload_file_already_exists(_mock_contains, _mock_exists):
     # Mock the authentication
     mock_user = UserInfo(user_id=123, username="test_user")

genai/tests/unit/test_prompt.py

@@ -25,12 +25,11 @@ def test_process_raw_messages_ignores_unknown_roles():
 
 
 def test_prepare_prompt_structure():
-    system_prompt = "You are a helpful assistant. Context: {context}"
     query = "What's a good recipe with eggs?"
     docs = "Here are some egg-based recipes."
     messages = [AIMessage(content="Hi there!")]
 
-    prompt = prepare_prompt(system_prompt, query, docs, messages)
+    prompt = prepare_prompt(query, docs, messages)
 
     assert hasattr(prompt, "to_messages")
     final_messages = prompt.to_messages()
@@ -39,12 +38,11 @@ def test_prepare_prompt_structure():
 
 
 def test_prepare_prompt_includes_docs_context():
-    system_prompt = "Use this: {context}"
     query = "Tell me something"
     docs = "Documented info"
     messages = []
 
-    prompt = prepare_prompt(system_prompt, query, docs, messages)
+    prompt = prepare_prompt(query, docs, messages)
     rendered = prompt.to_string()
     assert "Documented info" in rendered
     assert "Tell me something" in rendered

genai/tests/unit/test_retrieval.py

@@ -1,26 +1,35 @@
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, patch
 from langchain_core.documents import Document
 from service.rag_service import retrieve_similar_docs
 
 
-def test_retrieve_similar_docs_returns_joined_string():
+@patch('service.rag_service.get_vector_store')
+def test_retrieve_similar_docs_returns_joined_string(mock_get_vector_store):
+    collection_name = "test_collection"
     mock_vector_store = MagicMock()
-    mock_retriever = mock_vector_store.as_retriever.return_value
+    mock_retriever = MagicMock()
     mock_retriever.invoke.return_value = [
         Document(page_content="Doc 1"),
         Document(page_content="Doc 2")
     ]
+    mock_vector_store.as_retriever.return_value = mock_retriever
+    mock_get_vector_store.return_value = mock_vector_store
 
-    result = retrieve_similar_docs(mock_vector_store, "test query")
+    result = retrieve_similar_docs(collection_name, "test query")
 
     assert "Doc 1" in result
     assert "Doc 2" in result
     assert result == "Doc 1\n\nDoc 2"
 
 
-def test_retrieve_similar_docs_with_empty_results():
+@patch('service.rag_service.get_vector_store')
+def test_retrieve_similar_docs_with_empty_results(mock_get_vector_store):
+    collection_name = "test_collection"
     mock_vector_store = MagicMock()
-    mock_vector_store.as_retriever.return_value.invoke.return_value = []
+    mock_retriever = MagicMock()
+    mock_retriever.invoke.return_value = []
+    mock_vector_store.as_retriever.return_value = mock_retriever
+    mock_get_vector_store.return_value = mock_vector_store
 
-    result = retrieve_similar_docs(mock_vector_store, "irrelevant query")
+    result = retrieve_similar_docs(collection_name, "irrelevant query")
     assert result == ""