Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the direct genai route from the gateway configurations and adds a proxy controller plus necessary beans to forward both multipart and non-multipart requests for file uploads to the GenAI service.
- Removes
genairoute from prod and dev YAML configs and reordersuser/chatroutes in dev - Introduces
RestTemplateand multipart resolver beans - Adds
FileUploadProxyControllerto proxy/genai/**requests to the GenAI service
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/api-gw/src/main/resources/application.yaml | Removed genai route so /genai/** is now handled by controller |
| server/api-gw/src/main/resources/application-dev.yml | Removed genai route and reordered user/chat routes |
| server/api-gw/src/main/java/com/continiousdisappointment/apigw/config/RestTemplateConfig.java | Added a RestTemplate bean |
| server/api-gw/src/main/java/com/continiousdisappointment/apigw/config/MultipartConfig.java | Configured StandardServletMultipartResolver bean for lazy multipart handling |
| server/api-gw/src/main/java/com/continiousdisappointment/apigw/config/FileUploadProxyController.java | Implements proxy endpoint for /genai/** and forwards files/headers |
Comments suppressed due to low confidence (1)
server/api-gw/src/main/java/com/continiousdisappointment/apigw/config/FileUploadProxyController.java:16
- [nitpick] There are no tests for the new
FileUploadProxyController. Consider adding unit and integration tests covering both multipart and non-multipart scenarios to ensure headers, paths, and bodies are forwarded correctly.
@RestController
...pi-gw/src/main/java/com/continiousdisappointment/apigw/config/FileUploadProxyController.java
Show resolved
Hide resolved
...pi-gw/src/main/java/com/continiousdisappointment/apigw/config/FileUploadProxyController.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.