fix: change client demo logic to match upcomming spec

Author: stark-cybertech

server/matching/src/main/java/meet_at_mensa/matching/client/UserClient.java

@@ -132,15 +132,35 @@ private User getUserByAuthID(String authID) {
     public UserCollection getDemoUsers() {
 
         // create empty UserCollection
-        UserCollection users = new UserCollection();
+        UserCollection demoUsers = new UserCollection();
 
-        // get each user individually
-        for (String authID : List.of("TestUser001", "TestUser002", "TestUser003")) {
-            users.addUsersItem(getUserByAuthID(authID));
-        }
+        // create instance of the API
+        UserApi apiInstance = new UserApi(this.defaultClient);
 
-        // return userCollection
-        return users;
+        try {
+
+            org.openapitools.client.model.UserCollection userCollectionClient;
+
+            // request user Object from user-service
+            // TODO: Uncomment after API update
+            // userCollectionClient = apiInstance.getApiV2UsersDemo();
+            userCollectionClient = null;
+
+            // Convert to server users and add to list
+            for (org.openapitools.client.model.User userClient : userCollectionClient.getUsers()) {
+                
+                demoUsers.addUsersItem(
+                    convertClientUserToServerUser(userClient)
+                );
+
+            }
+
+            // convert to server-type object and return
+            return demoUsers;
+
+        } catch (Exception e) {
+            throw new RestException(e.toString());
+        }
 
     }
 

server/matching/src/main/java/meet_at_mensa/matching/service/MatchingService.java

@@ -485,8 +485,7 @@ public Group createDemoMatch(MatchRequestNew demoRequest) {
         MatchRequest thisRequest = requestService.registerRequest(demoRequest);
 
         // get demo users from UserService
-        // TODO: This is a placeholder, Implement after API update.
-        UserCollection demoUsers = new UserCollection();
+        UserCollection demoUsers = userClient.getDemoUsers();
 
         // Create a collection of demo requests
         MatchRequestCollection demoUserRequests = new MatchRequestCollection();