Skip to content

Commit 869f1cb

Browse files
committed
fix: update advancedSearch call and rename getPublicPublishedCourses to getPublishedCourses
1 parent 7c59930 commit 869f1cb

File tree

1 file changed

+18
-13
lines changed
  • server/skillforge-course/src/main/java/com/gitittogether/skillForge/server/course/controller/courses

1 file changed

+18
-13
lines changed

server/skillforge-course/src/main/java/com/gitittogether/skillForge/server/course/controller/courses/CourseController.java

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ public ResponseEntity<List<CourseSummaryResponse>> getPublicCourses() {
5757
}
5858

5959
@GetMapping("/public/published")
60-
public ResponseEntity<List<CourseResponse>> getPublicPublishedCourses() {
60+
public ResponseEntity<List<CourseSummaryResponse>> getPublishedCourses() {
6161
log.info("Fetching public and published courses for landing page");
62-
List<CourseResponse> responses = courseService.getPublicPublishedCourses();
62+
List<CourseSummaryResponse> responses = courseService.getPublishedCourses();
6363
return ResponseEntity.ok(responses);
6464
}
6565

@@ -121,18 +121,23 @@ public ResponseEntity<Void> unbookmarkCourse(@PathVariable String courseId, @Pat
121121

122122
@GetMapping("/search")
123123
public ResponseEntity<List<CourseResponse>> searchCourses(
124-
@RequestParam(required = false) String instructor,
125-
@RequestParam(required = false) Level level,
126-
@RequestParam(required = false) Language language,
127-
@RequestParam(required = false) String skill,
128-
@RequestParam(required = false) String category,
129-
@RequestParam(required = false) String title
124+
@RequestParam(required = false) String instructor,
125+
@RequestParam(required = false) Level level,
126+
@RequestParam(required = false) Language language,
127+
@RequestParam(required = false) String skill,
128+
@RequestParam(required = false) String category,
129+
@RequestParam(required = false) String title,
130+
@RequestParam(required = false) boolean isPublished,
131+
@RequestParam(required = false) boolean isPublic
130132
) {
131-
log.info("Advanced search: instructor={}, level={}, language={}, skill={}, category={}, title={}", instructor, level, language, skill, category, title);
132-
List<CourseResponse> responses = courseService.advancedSearch(instructor, level, language, skill, category, title);
133-
return ResponseEntity.ok(responses);
134-
}
135-
133+
log.info("Advanced search: instructor={}, level={}, language={}, skill={}, category={}, title={}, isPublished={}, isPublic={}",
134+
instructor, level, language, skill, category, title, isPublished, isPublic);
135+
List<CourseResponse> responses = courseService.advancedSearch(instructor, level, language, skill, category, title, isPublished, isPublic);
136+
return ResponseEntity.ok(responses);
137+
}
138+
139+
140+
136141
@GetMapping("/search/instructor/{instructor}")
137142
public ResponseEntity<List<CourseResponse>> getCoursesByInstructor(@PathVariable String instructor) {
138143
log.info("Fetching courses by instructor: {}", instructor);

0 commit comments

Comments
 (0)