Skip to content

Commit 08ba8fc

Browse files
committed
remove sonarlint
1 parent cda6861 commit 08ba8fc

File tree

7 files changed

+14
-29
lines changed

7 files changed

+14
-29
lines changed

.github/workflows/server-linters.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ jobs:
2222
- name: Setup Gradle
2323
uses: gradle/actions/setup-gradle@v4
2424

25-
- name: Server lint
26-
run: |
27-
cd server
28-
gradle sonarLintMain
29-
3025
- name: Server formatting
3126
run: |
3227
cd server

server/build.gradle

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ plugins {
33
id 'org.springframework.boot' version '3.4.4'
44
id 'org.flywaydb.flyway' version '9.22.3'
55
id 'com.diffplug.spotless' version '5.0.0'
6-
id 'name.remal.sonarlint' version '6.0.0-rc-2'
76
}
87

98
apply plugin: 'io.spring.dependency-management'
@@ -45,8 +44,4 @@ spotless {
4544
java {
4645
googleJavaFormat()
4746
}
48-
}
49-
50-
sonarLint {
51-
isGeneratedCodeIgnored = true
5247
}

server/src/main/java/de/tum/cit/aet/devops/teamserverdown/config/SecurityConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package de.tum.cit.aet.devops.teamserverdown.config;
22

3-
import java.util.List;
4-
53
import de.tum.cit.aet.devops.teamserverdown.security.JWTAuthenticationFilter;
4+
import java.util.List;
65
import org.springframework.context.annotation.Bean;
76
import org.springframework.context.annotation.Configuration;
87
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
@@ -31,7 +30,8 @@ public SecurityFilterChain securityFilterChain(
3130
http.cors(cors -> {})
3231
.httpBasic(AbstractHttpConfigurer::disable)
3332
.formLogin(AbstractHttpConfigurer::disable)
34-
.sessionManagement(session -> session.sessionCreationPolicy(SessionCreationPolicy.STATELESS))
33+
.sessionManagement(
34+
session -> session.sessionCreationPolicy(SessionCreationPolicy.STATELESS))
3535
.addFilterBefore(jwtAuthenticationFilter, UsernamePasswordAuthenticationFilter.class);
3636

3737
return http.build();

server/src/main/java/de/tum/cit/aet/devops/teamserverdown/model/User.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
import jakarta.persistence.*;
44

55
@Entity
6-
@Table(name = "\"user\"", indexes = {
7-
@Index(name = "idx_user_email", columnList = "email")
8-
})
6+
@Table(
7+
name = "\"user\"",
8+
indexes = {@Index(name = "idx_user_email", columnList = "email")})
99
public class User {
1010
@Id
1111
@GeneratedValue(strategy = GenerationType.IDENTITY)

server/src/main/java/de/tum/cit/aet/devops/teamserverdown/security/JWTAuthenticationFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ protected boolean shouldNotFilter(HttpServletRequest request) {
5252
String path = request.getServletPath();
5353
return path.startsWith("/v3/api-docs") || path.startsWith("/swagger-ui");
5454
}
55-
}
55+
}

server/src/main/java/de/tum/cit/aet/devops/teamserverdown/security/JWTValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
public class JWTValidator {
2222
private static final String JWKS_URL =
23-
System.getenv("IDP_URI") + "/protocol/openid-connect/certs";
23+
System.getenv("IDP_URI") + "/protocol/openid-connect/certs";
2424

2525
public DecodedJWT validateToken(String token) throws JWTVerificationException {
2626
DecodedJWT decoded = JWT.decode(token);

server/src/main/java/de/tum/cit/aet/devops/teamserverdown/services/UserService.java

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,16 @@ public UserService(UserRepository userRepository) {
1414
}
1515

1616
public User getOrCreateUser(DecodedJWT decoded) {
17-
String email = decoded.getClaim("email").asString();
18-
String firstName = decoded.getClaim("given_name").asString();
19-
String lastName = decoded.getClaim("family_name").asString();
20-
String userName = decoded.getClaim("preferred_username").asString();
17+
String email = decoded.getClaim("email").asString();
18+
String firstName = decoded.getClaim("given_name").asString();
19+
String lastName = decoded.getClaim("family_name").asString();
20+
String userName = decoded.getClaim("preferred_username").asString();
2121

22-
return userRepository
22+
return userRepository
2323
.findByEmail(email)
2424
.orElseGet(
2525
() -> {
26-
User newUser = new User(
27-
firstName,
28-
lastName,
29-
userName,
30-
email
31-
);
26+
User newUser = new User(firstName, lastName, userName, email);
3227

3328
return userRepository.save(newUser);
3429
});

0 commit comments

Comments
 (0)