Merge branch 'master' into master

Author: AEW745

.eslintrc.js

@@ -15,7 +15,7 @@ jobs:
       - name: Set up node
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 20
 
       - name: Install yarn
         run: npm install -g yarn

.github/FUNDING.yml

@@ -1,6 +1,10 @@
 name: Test & Publish
 
 on:
+  pull_request:
+    branches:
+      - master
+
   push:
     branches:
       - master
@@ -15,7 +19,7 @@ jobs:
       - name: Set up node
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 20
 
       - name: Install yarn
         run: npm install -g yarn
@@ -28,6 +32,7 @@ jobs:
 
   publish-npm:
     needs: test
+    if: github.event_name == 'push'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code with ADMIN_TOKEN
@@ -46,25 +51,25 @@ jobs:
       - name: Set up node
         uses: actions/setup-node@v1
         with:
-          node-version: 14
+          node-version: 20
 
       - name: Install yarn
         run: npm install -g yarn
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        
+
       - name: Cache node modules
         uses: actions/cache@v1
         with:
           path: node_modules
           key: yarn-deps-${{ hashFiles('yarn.lock') }}
           restore-keys: |
             yarn-deps-${{ hashFiles('yarn.lock') }}
-            
+
       - name: Create Release
         env:
-          GH_TOKEN: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.ADMIN_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
         run: |
           npx auto shipit

.github/workflows/doc-publish.yml

@@ -0,0 +1,49 @@
+name: Run tests
+
+on:
+  workflow_dispatch
+
+
+jobs:
+  test:
+    permissions:
+      id-token: write
+
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Lint lib/
+        run: yarn lint
+
+      - id: auth
+        name: Generate ID Token
+        uses: google-github-actions/auth@v2
+        with:
+          token_format: id_token
+          workload_identity_provider: ${{ vars.workload_identity_provider }}
+          service_account: ${{ vars.service_account }}
+          id_token_audience: "https://${{ vars.forwarder_hostname }}"
+          id_token_include_email: true
+
+      - name: Run tests
+        env:
+          API_KEY: ${{ secrets.API_KEY }}
+          COOKIE: ${{ secrets.COOKIE }}
+          COOKIE_2: ${{ secrets.COOKIE_2 }}
+          FORWARDER_HOSTNAME: ${{ vars.forwarder_hostname }}
+          ID_TOKEN: ${{ steps.auth.outputs.id_token }}
+        run: yarn test
+

.github/workflows/npmpublish.yml

@@ -9,7 +9,6 @@
     <a href="https://standardjs.com"><img src="https://img.shields.io/badge/code_style-standard-blue.svg?style=flat-square" alt="JavaScript Style Guide"/></a>
     <a href="https://discord.gg/R5GVSyTVGv"><img src="https://img.shields.io/badge/discord-noblox.js-blue.svg?style=flat-square" alt="noblox.js Discord"/></a>
     <a href="https://npmjs.org/noblox.js"><img src="https://img.shields.io/npm/v/noblox.js.svg?style=flat-square" alt="NPM package"/>
-    <a href="https://travis-ci.org/noblox/noblox.js"><img src="https://img.shields.io/travis/noblox/noblox.js/master.svg?style=flat-square" alt="Travis Build Status"/></a></a>
 </p>
 
 <p align="center">
@@ -30,15 +29,15 @@
 
 `noblox.js` is an open-source Roblox API wrapper written in JavaScript (with TypeScript compatibility) as a fork from sentanos's <a href="https://github.com/sentanos/roblox-js"> roblox-js module</a>.
 
-This NPM package enables operations froms the [Roblox website](https://www.roblox.com) to be executed via NodeJS; many individuals leverage `noblox.js` along side [Roblox's HTTPService](http://wiki.roblox.com/index.php?title=API:Class/HttpService) to create in-game scripts that interact with the website, i.e. promote users, shout events, and so on, or to create Discord utiltiies to manage their community.
+This NPM package enables operations froms the [Roblox website](https://www.roblox.com) to be executed via NodeJS; many individuals leverage `noblox.js` along side [Roblox's HTTPService](http://wiki.roblox.com/index.php?title=API:Class/HttpService) to create in-game scripts that interact with the website, i.e. promote users, shout events, and so on, or to create Discord utilities to manage their community.
 
 If you are looking for more information on how to create something like this, check out [our sister library, `noblox.js-server`](https://github.com/noblox/noblox.js-server) or [our YouTube series](https://www.youtube.com/playlist?list=PLEW4K4VqMUb_VMA3Yp9LI4gReRyVWGTnU). Keep in mind that these resources may not always be up to date, so it is **highly** encouraged that you learn to use the `noblox.js` library directly.
 
 ---
 
 ## Prerequisites
 
-- [**Node.js®**](https://nodejs.org/en/download/current/)
+- [**Node.js®**](https://nodejs.org/en/download/current/) v18.18 or later
 
 ---
 

.github/workflows/run-tests.yml

@@ -0,0 +1,34 @@
+import jest from "eslint-plugin-jest";
+import globals from "globals";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends("standard", "plugin:jest/recommended"), {
+    plugins: {
+        jest,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.commonjs,
+            ...globals.node,
+            Atomics: "readonly",
+            SharedArrayBuffer: "readonly",
+        },
+
+        ecmaVersion: 2018,
+        sourceType: "commonjs",
+    },
+
+    rules: {},
+}];

.travis.yml

@@ -1,5 +1,6 @@
 // Includes
 const http = require('../util/http.js').func
+const RobloxAPIError = require('../util/apiError.js')
 
 // Args
 exports.required = ['userId']
@@ -25,14 +26,11 @@ function getUserSocialLinks (userId, jar) {
       resolveWithFullResponse: true
     }
   })
-    .then(({ statusCode, body }) => {
-      const { errors } = JSON.parse(body)
-      if (statusCode === 200) {
-        return JSON.parse(body)
-      } else if (statusCode === 400) {
-        throw new Error(`${errors[0].message} | userId: ${userId}`)
+    .then((res) => {
+      if (res.statusCode === 200) {
+        return JSON.parse(res.body)
       } else {
-        throw new Error(`An unknown error occurred with getUserSocialLinks() | [${statusCode}] userId: ${userId}`)
+        throw new RobloxAPIError(res)
       }
     })
 }

README.md

@@ -1,6 +1,7 @@
 // Includes
 const http = require('../util/http.js').func
 const getGeneralToken = require('../util/getGeneralToken.js').func
+const RobloxAPIError = require('../util/apiError.js')
 
 // Args
 exports.required = ['userId']
@@ -37,13 +38,7 @@ function block (jar, token, userId) {
         if (res.statusCode === 200) {
           resolve()
         } else {
-          const body = JSON.parse(res.body) || {}
-          if (body.errors && body.errors.length > 0) {
-            const errors = body.errors.map((e) => {
-              return e.message
-            })
-            reject(new Error(`${res.statusCode} ${errors.join(', ')}`))
-          }
+          reject(new RobloxAPIError(res))
         }
       })
   })