Will return new status if pending txs already expired.

Author: eanzhao

src/AElf.WebApp.Application.Chain/Services/TransactionResultAppService.cs

@@ -152,6 +152,14 @@ public async Task<TransactionResultDto> GetTransactionResultV2Async(string trans
         output.Transaction = _objectMapper.Map<Transaction, TransactionDto>(transaction);
         output.TransactionSize = transaction?.CalculateSize() ?? 0;
 
+        var chain = await _blockchainService.GetChainAsync();
+        if (transactionResult.Status == TransactionResultStatus.Pending &&
+            chain.BestChainHeight - output.Transaction?.RefBlockNumber > KernelConstants.ReferenceBlockValidPeriod)
+        {
+            output.StatusV2 = TransactionResultStatus.Expired.ToString().ToUpper();
+            return output;
+        }
+
         if (transactionResult.Status != TransactionResultStatus.NotExisted)
         {
             await FormatTransactionParamsAsync(output.Transaction, transaction.Params);
@@ -179,14 +187,6 @@ await _transactionResultProxyService.InvalidTransactionResultService.GetInvalidT
                 return output;
             }
         }
-        
-        var chain = await _blockchainService.GetChainAsync();
-        if (chain.BestChainHeight - output.Transaction?.RefBlockNumber > KernelConstants.ReferenceBlockValidPeriod 
-            && transactionResult.Status == TransactionResultStatus.NotExisted)
-        {
-            output.StatusV2 = TransactionResultStatus.Expired.ToString().ToUpper();
-            return output;
-        }
 
         return output;
     }

test/AElf.WebApp.Application.Chain.Tests/BlockChainAppServiceTest.cs

@@ -698,14 +698,11 @@ public async Task Get_TransactionResultV2_Expired_Test()
 
         // Broadcast expired transaction
         await _osTestHelper.BroadcastTransactions(new List<Transaction> { transaction });
-        
-        // Try to package this transaction
-        await _osTestHelper.MinedOneBlock();
 
         // Check transaction status
         var response = await GetResponseAsObjectAsync<TransactionResultDto>(
             $"/api/blockChain/transactionResultV2?transactionId={transactionHex}");
-        // response.StatusV2.ShouldBe(TransactionResultStatus.Expired.ToString());
+        response.StatusV2.ShouldBe(TransactionResultStatus.Expired.ToString().ToUpper());
     }
 
     private async Task MineSomeBlocks(int blockNumber)