TAA filtering almost done. VXGI bug fixed and G-Buffer packed

Author: AEspinosaDev

examples/rotating-kabuto/main.cpp

@@ -32,7 +32,7 @@ int main() {
         window->init();
 
         Systems::RendererSettings settings{};
-        settings.samplesMSAA = MSAASamples::x1;
+        settings.samplesMSAA = MSAASamples::x4;
         settings.clearColor  = Vec4(0.0, 0.0, 0.0, 1.0);
 
         Systems::BaseRenderer* renderer =

include/engine/core/passes/TAA_pass.h

@@ -0,0 +1,66 @@
+/*
+    This file is part of Vulkan-Engine, a simple to use Vulkan based 3D library
+
+    MIT License
+
+    Copyright (c) 2023 Antonio Espinosa Garcia
+
+*/
+#ifndef TAA_PASS_H
+#define TAA_PASS_H
+#include <engine/core/passes/postprocess_pass.h>
+
+VULKAN_ENGINE_NAMESPACE_BEGIN
+
+namespace Core {
+
+/*
+Tempopral Filtering Pass.
+*/
+class TAAPass final : public PostProcessPass<2, 0>
+{
+  public:
+    /*
+
+               Input Attachments:
+               -
+               - Color
+               - Velocity Buffer
+
+               Output Attachments:
+               -
+               - Filtered Color
+               - Prev Filtered Color
+
+           */
+    TAAPass(Graphics::Device*        device,
+            const PassLinkage<2, 0>& linkage,
+            Extent2D                 extent,
+            ColorFormatType          colorFormat,
+            bool                     isDefault = true)
+        : PostProcessPass(device,
+                          linkage,
+                          extent,
+                          colorFormat,
+                          ENGINE_RESOURCES_PATH "shaders/aa/taa.glsl",
+                          "TAA",
+                          isDefault) {
+        m_interAttachments.resize(1); //Prev Frame
+    }
+
+    void setup_out_attachments(std::vector<Graphics::AttachmentConfig>&  attachments,
+        std::vector<Graphics::SubPassDependency>& dependencies) override;
+
+    void setup_uniforms(std::vector<Graphics::Frame>& frames) override;
+
+    void create_framebuffer() override;
+
+    void link_input_attachments() override;
+
+    void execute(Graphics::Frame& currentFrame, Scene* const scene, uint32_t presentImageIndex = 0) override;
+};
+
+} // namespace Core
+VULKAN_ENGINE_NAMESPACE_END
+
+#endif

include/engine/core/passes/bloom_pass.h

@@ -29,7 +29,7 @@ both X and Y axes.
 A (first downsampled image).
 - Finally, we mix the overall bloom contribution into the HDR source image, with a strong bias towards the HDR source.
 */
-class BloomPass : public BaseGraphicPass
+class BloomPass final : public BaseGraphicPass
 {
   protected:
     ColorFormatType m_colorFormat = SRGBA_16F;

include/engine/core/passes/composition_pass.h

@@ -47,7 +47,7 @@ struct VXGI { // Settings for Voxel Based GI
     uint32_t updateMode        = 0;
 };
 
-class CompositionPass : public BaseGraphicPass
+class CompositionPass final : public BaseGraphicPass
 {
     /*Setup*/
     ColorFormatType m_colorFormat;
@@ -59,8 +59,6 @@ class CompositionPass : public BaseGraphicPass
     };
     std::vector<FrameDescriptors> m_descriptors;
 
-    Graphics::Image m_prevFrame;
-
     struct Settings {
         OutputBuffer outputBuffer = OutputBuffer::LIGHTING;
         int          enableAO     = 1;
@@ -70,8 +68,6 @@ class CompositionPass : public BaseGraphicPass
     };
     Settings m_settings = {};
 
-    void create_prev_frame_image();
-
   public:
     /*
             Input Attachments:
@@ -138,9 +134,6 @@ class CompositionPass : public BaseGraphicPass
 
     void update_uniforms(uint32_t frameIndex, Scene* const scene) override;
 
-    void resize_attachments() override;
-
-    void cleanup() override;
 };
 } // namespace Core
 VULKAN_ENGINE_NAMESPACE_END

include/engine/core/passes/enviroment_pass.h

@@ -21,7 +21,7 @@ This pass does three things:
 - Performs a second renderpass to compute the diuffuse irradiance cubemap.
 - Performs a third renderpass to compute the specular irradiance cubemap.
 */
-class EnviromentPass : public BaseGraphicPass
+class EnviromentPass final : public BaseGraphicPass
 {
     ColorFormatType         m_format;
     Graphics::DescriptorSet m_envDescriptorSet;

include/engine/core/passes/forward_pass.h

@@ -20,7 +20,7 @@ namespace Core {
 /*
 STANDARD FORWARD LIGHTING PASS
 */
-class ForwardPass : public BaseGraphicPass
+class ForwardPass final : public BaseGraphicPass
 {
     /*Setup*/
     ColorFormatType m_colorFormat;

include/engine/core/passes/geometry_pass.h

@@ -18,7 +18,7 @@ namespace Core {
 /*
 DEFERRED RENDERING GEOMETRY PASS
 */
-class GeometryPass : public BaseGraphicPass
+class GeometryPass final : public BaseGraphicPass
 {
     /*Setup*/
     ColorFormatType m_colorFormat;
@@ -43,10 +43,10 @@ class GeometryPass : public BaseGraphicPass
 
         Output Attachments:
         -
-        - Normal + VelX buffer
+        - Normal buffer
         - Albedo buffer
         - Material buffer
-        - Emmissive + VelY buffer
+        - Velocity + Emissive buffer
         - Depth buffer
     */
     GeometryPass(Graphics::Device*        device,

include/engine/core/passes/gui_pass.h

@@ -20,17 +20,17 @@ attachment. As it is designed to be at the last step of the pipeline.
 
 This pass takes the default pass image (swapchain image)
 */
-class GUIPass : public BaseGraphicPass
+class GUIPass final : public BaseGraphicPass
 {
 
   public:
     GUIPass(Graphics::Device* device, VkExtent2D extent)
         : BaseGraphicPass(device, extent, 1, 1, true, true, "GUI") {
     }
 
-    virtual void setup_uniforms(std::vector<Graphics::Frame>& frames) override {
+    void setup_uniforms(std::vector<Graphics::Frame>& frames) override {
     }
-    virtual void setup_shader_passes() override {
+    void setup_shader_passes() override {
     }
 
     void setup_out_attachments(std::vector<Graphics::AttachmentConfig>&  attachments,

include/engine/core/passes/postprocess_pass.h

@@ -64,7 +64,7 @@ void PostProcessPass<numberIN, numberOUT>::setup_out_attachments(
                                    1,
                                    this->m_isDefault ? LAYOUT_PRESENT : LAYOUT_SHADER_READ_ONLY_OPTIMAL,
                                    LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
-                                   this->m_isDefault ? IMAGE_USAGE_TRANSIENT_ATTACHMENT | IMAGE_USAGE_COLOR_ATTACHMENT
+                                   this->m_isDefault ? IMAGE_USAGE_TRANSIENT_ATTACHMENT | IMAGE_USAGE_COLOR_ATTACHMENT 
                                                      : IMAGE_USAGE_COLOR_ATTACHMENT | IMAGE_USAGE_SAMPLED,
                                    COLOR_ATTACHMENT,
                                    ASPECT_COLOR,

include/engine/core/passes/precomposition_pass.h

@@ -36,7 +36,7 @@ Pre-composition pass called before the Composition (Lighting) pass in a deferred
 SSAO and other lighting effects, such as blurring raytraced shadows by bilinear filering them, in order to be used in
 future lighting passes.
 */
-class PreCompositionPass : public BaseGraphicPass
+class PreCompositionPass final : public BaseGraphicPass
 {
     /*Descriptors*/
     struct FrameDescriptors {