Skip to content

Commit 23686df

Browse files
berrangehuth
authored andcommitted
tests/functional: remove all class level fields
A number of fields are set at the class level on QemuBaseTest, even though the exact same named field is then set at the object level later in most cases. The 'self.logger' initialization in ACPI bits test needs to be removed since 'self.log' won't exist at that point in the flow. It already initialized 'self.logger' later in the setUp() method, so the __init__ method was redundant. Signed-off-by: Daniel P. Berrangé <[email protected]> Message-ID: <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: Thomas Huth <[email protected]>
1 parent 6d19d09 commit 23686df

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

tests/functional/qemu_test/testcase.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@
3333

3434
class QemuBaseTest(unittest.TestCase):
3535

36-
arch = None
37-
38-
workdir = None
39-
log = None
40-
logdir = None
41-
4236
'''
4337
@params compressed: filename, Asset, or file-like object to uncompress
4438
@params format: optional compression format (gzip, lzma)

tests/functional/test_acpi_bits.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ def __init__(self, *args, **kwargs):
119119

120120
self._debugcon_addr = '0x403'
121121
self._debugcon_log = 'debugcon-log.txt'
122-
self.logger = self.log
123122

124123
def _print_log(self, log):
125124
self.logger.info('\nlogs from biosbits follows:')

0 commit comments

Comments
 (0)