Skip to content

Commit 51514a3

Browse files
philmdrth7680
authored andcommitted
tests/qtest: Skip Aarch64 VMapple machine
First, the VMapple machine only works with the ARM 'host' CPU type, which isn't accepted for QTest: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Second, the QTest framework expects machines to be createable without specifying optional arguments, however the VMapple machine requires few of them: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: No firmware specified $ qemu-system-aarch64 -M vmapple -accel qtest -bios /dev/null qemu-system-aarch64: No AUX device. Please specify one as pflash drive. Restrict this machine with QTest so we can at least run check-qtest, otherwise we get: $ make check-qtest-aarch64 qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Broken pipe ../tests/qtest/libqtest.c:199: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ... 7/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/test-hmp ERROR 24.71s killed by signal 6 SIGABRT 2/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test ERROR 71.23s killed by signal 6 SIGABRT Suggested-by: Fabiano Rosas <[email protected]> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: Richard Henderson <[email protected]> Message-ID: <[email protected]>
1 parent bd20bc4 commit 51514a3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/qtest/libqtest.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1788,6 +1788,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
17881788
if (!strncmp("xenfv", machines[i].name, 5) ||
17891789
g_str_equal("xenpv", machines[i].name) ||
17901790
g_str_equal("xenpvh", machines[i].name) ||
1791+
g_str_equal("vmapple", machines[i].name) ||
17911792
g_str_equal("nitro-enclave", machines[i].name)) {
17921793
continue;
17931794
}

0 commit comments

Comments
 (0)