Skip to content

Commit 5afb837

Browse files
miszrMichael Tokarev
authored andcommitted
target/sparc: Fix register selection for all F*TOx and FxTO* instructions
A bug was introduced in commit 0bba757 which causes the fdtox and fqtox instructions to incorrectly select the destination registers. More information and a test program can be found in issue #2802. Cc: [email protected] Fixes: 0bba757 ("target/sparc: Perform DFPREG/QFPREG in decodetree") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2802 Signed-off-by: Mikael Szreder <[email protected]> Acked-by: Artyom Tarasenko <[email protected]> [rth: Squash patches together, since the second fixes a typo in the first.] Signed-off-by: Richard Henderson <[email protected]> Message-ID: <[email protected]> (cherry picked from commit 807c3eb) Signed-off-by: Michael Tokarev <[email protected]>
1 parent dffec2d commit 5afb837

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

target/sparc/insns.decode

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,12 +321,12 @@ FdMULq 10 ..... 110100 ..... 0 0110 1110 ..... @q_d_d
321321
FNHADDs 10 ..... 110100 ..... 0 0111 0001 ..... @r_r_r
322322
FNHADDd 10 ..... 110100 ..... 0 0111 0010 ..... @d_d_d
323323
FNsMULd 10 ..... 110100 ..... 0 0111 1001 ..... @d_r_r
324-
FsTOx 10 ..... 110100 00000 0 1000 0001 ..... @r_r2
325-
FdTOx 10 ..... 110100 00000 0 1000 0010 ..... @r_d2
326-
FqTOx 10 ..... 110100 00000 0 1000 0011 ..... @r_q2
327-
FxTOs 10 ..... 110100 00000 0 1000 0100 ..... @r_r2
328-
FxTOd 10 ..... 110100 00000 0 1000 1000 ..... @d_r2
329-
FxTOq 10 ..... 110100 00000 0 1000 1100 ..... @q_r2
324+
FsTOx 10 ..... 110100 00000 0 1000 0001 ..... @d_r2
325+
FdTOx 10 ..... 110100 00000 0 1000 0010 ..... @d_d2
326+
FqTOx 10 ..... 110100 00000 0 1000 0011 ..... @d_q2
327+
FxTOs 10 ..... 110100 00000 0 1000 0100 ..... @r_d2
328+
FxTOd 10 ..... 110100 00000 0 1000 1000 ..... @d_d2
329+
FxTOq 10 ..... 110100 00000 0 1000 1100 ..... @q_d2
330330
FiTOs 10 ..... 110100 00000 0 1100 0100 ..... @r_r2
331331
FdTOs 10 ..... 110100 00000 0 1100 0110 ..... @r_d2
332332
FqTOs 10 ..... 110100 00000 0 1100 0111 ..... @r_q2

0 commit comments

Comments
 (0)