Skip to content

Commit d31d37f

Browse files
danielhbalistair23
authored andcommitted
docs: deprecate RISC-V default machine option
Commit 5b4beba ("RISC-V Spike Machines") added the Spike machine and made it default for qemu-system-riscv32/64. It was the first RISC-V machine added in QEMU so setting it as default was sensible. Today we have 7 riscv64 and 6 riscv32 machines and having 'spike' as default machine is not intuitive. For example, [1] is a bug that was opened with the 'virt' board in mind, but given that the user didn't pass a '-machine' option, the user was using 'spike' without knowing. Being explicit in the command line is desirable when we have a handful of boards available, so deprecate the default machine setting from RISC-V. [1] https://gitlab.com/qemu-project/qemu/-/issues/2467 Suggested-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Daniel Henrique Barboza <[email protected]> Reviewed-by: Alistair Francis <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-ID: <[email protected]> Signed-off-by: Alistair Francis <[email protected]>
1 parent 53f3a13 commit d31d37f

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

docs/about/deprecated.rst

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,23 @@ online to check that this board did not completely bitrot yet). It is
304304
recommended to use another MIPS machine for future MIPS code development
305305
instead.
306306

307+
RISC-V default machine option (since 10.0)
308+
''''''''''''''''''''''''''''''''''''''''''
309+
310+
RISC-V defines ``spike`` as the default machine if no machine option is
311+
given in the command line. This happens because ``spike`` is the first
312+
RISC-V machine implemented in QEMU and setting it as default was
313+
convenient at that time. Now we have 7 riscv64 and 6 riscv32 machines
314+
and having ``spike`` as a default is no longer justified. This default
315+
will also promote situations where users think they're running ``virt``
316+
(the most used RISC-V machine type in 10.0) when in fact they're
317+
running ``spike``.
318+
319+
Removing the default machine option forces users to always set the machine
320+
they want to use and avoids confusion. Existing users of the ``spike``
321+
machine must ensure that they're setting the ``spike`` machine in the
322+
command line (``-M spike``).
323+
307324

308325
Backend options
309326
---------------

0 commit comments

Comments
 (0)