Skip to content

Commit f0095c8

Browse files
philmdlegoater
authored andcommitted
hw/misc/aspeed_scu: Set MemoryRegionOps::impl::access_size to 32-bit
All MemoryRegionOps::read/write() handlers switch over a 32-bit aligned value, because converted using TO_REG(), which is defined as: #define TO_REG(offset) ((offset) >> 2) So all implementations are 32-bit. Set min/max access_size accordingly. Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Andrew Jeffery <[email protected]> Link: https://lore.kernel.org/qemu-devel/[email protected] Signed-off-by: Cédric Le Goater <[email protected]>
1 parent 0f15892 commit f0095c8

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

hw/misc/aspeed_scu.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,10 @@ static const MemoryRegionOps aspeed_ast2400_scu_ops = {
427427
.read = aspeed_scu_read,
428428
.write = aspeed_ast2400_scu_write,
429429
.endianness = DEVICE_LITTLE_ENDIAN,
430+
.impl = {
431+
.min_access_size = 4,
432+
.max_access_size = 4,
433+
},
430434
.valid = {
431435
.min_access_size = 1,
432436
.max_access_size = 4,
@@ -437,6 +441,8 @@ static const MemoryRegionOps aspeed_ast2500_scu_ops = {
437441
.read = aspeed_scu_read,
438442
.write = aspeed_ast2500_scu_write,
439443
.endianness = DEVICE_LITTLE_ENDIAN,
444+
.impl.min_access_size = 4,
445+
.impl.max_access_size = 4,
440446
.valid.min_access_size = 4,
441447
.valid.max_access_size = 4,
442448
.valid.unaligned = false,
@@ -779,6 +785,8 @@ static const MemoryRegionOps aspeed_ast2600_scu_ops = {
779785
.read = aspeed_ast2600_scu_read,
780786
.write = aspeed_ast2600_scu_write,
781787
.endianness = DEVICE_LITTLE_ENDIAN,
788+
.impl.min_access_size = 4,
789+
.impl.max_access_size = 4,
782790
.valid.min_access_size = 4,
783791
.valid.max_access_size = 4,
784792
.valid.unaligned = false,
@@ -906,6 +914,8 @@ static const MemoryRegionOps aspeed_ast2700_scu_ops = {
906914
.read = aspeed_ast2700_scu_read,
907915
.write = aspeed_ast2700_scu_write,
908916
.endianness = DEVICE_LITTLE_ENDIAN,
917+
.impl.min_access_size = 4,
918+
.impl.max_access_size = 4,
909919
.valid.min_access_size = 1,
910920
.valid.max_access_size = 8,
911921
.valid.unaligned = false,
@@ -1028,6 +1038,8 @@ static const MemoryRegionOps aspeed_ast2700_scuio_ops = {
10281038
.read = aspeed_ast2700_scuio_read,
10291039
.write = aspeed_ast2700_scuio_write,
10301040
.endianness = DEVICE_LITTLE_ENDIAN,
1041+
.impl.min_access_size = 4,
1042+
.impl.max_access_size = 4,
10311043
.valid.min_access_size = 1,
10321044
.valid.max_access_size = 8,
10331045
.valid.unaligned = false,

0 commit comments

Comments
 (0)