Skip to content

Commit 15e3963

Browse files
authored
Rename third_party folder to Avoid Copybara g3 Errors (#148)
* rename third_party * fix ut * fix ut
1 parent 52d63a5 commit 15e3963

File tree

10 files changed

+6
-6
lines changed

10 files changed

+6
-6
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ unit-tests:
5151
coverage run -m unittest -v
5252

5353
check-test-coverage:
54-
coverage report -m --omit="jetstream/core/proto/*,jetstream/engine/tokenizer_pb2.py,jetstream/third_party/*" --fail-under=96
54+
coverage report -m --omit="jetstream/core/proto/*,jetstream/engine/tokenizer_pb2.py,jetstream/external_tokenizers/*" --fail-under=96

benchmarks/benchmark_serving.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
from jetstream.core.proto import jetstream_pb2
7474
from jetstream.core.proto import jetstream_pb2_grpc
7575
from jetstream.engine.token_utils import load_vocab
76-
from jetstream.third_party.llama3 import llama3_tokenizer
76+
from jetstream.external_tokenizers.llama3 import llama3_tokenizer
7777
import numpy as np
7878
from tqdm.asyncio import tqdm # pytype: disable=pyi-error
7979
import pandas

jetstream/engine/token_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from jetstream.engine import mock_utils
2929
from jetstream.engine import tokenizer_api
3030
from jetstream.engine import tokenizer_pb2
31-
from jetstream.third_party.llama3 import llama3_tokenizer
31+
from jetstream.external_tokenizers.llama3 import llama3_tokenizer
3232

3333
# ResultToken class to store tokens ids.
3434
ResultTokens = Any
File renamed without changes.
File renamed without changes.

jetstream/tests/engine/third_party/llama2/tokenizer.model renamed to jetstream/tests/engine/external_tokenizers/llama2/tokenizer.model

File renamed without changes.

jetstream/tests/engine/third_party/llama3/tokenizer.model renamed to jetstream/tests/engine/external_tokenizers/llama3/tokenizer.model

File renamed without changes.

jetstream/tests/engine/test_token_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def decode(self, t: int) -> str:
5555
class TokenUtilsTest(unittest.TestCase):
5656

5757
def setup_sentencepiece(self):
58-
self.tokenizer_path = "third_party/llama2/tokenizer.model"
58+
self.tokenizer_path = "external_tokenizers/llama2/tokenizer.model"
5959
current_dir = os.path.dirname(__file__)
6060
self.tokenizer_path = os.path.join(current_dir, self.tokenizer_path)
6161
print(f"model_path: {self.tokenizer_path}")
@@ -66,7 +66,7 @@ def setup_sentencepiece(self):
6666
self.jt_tokenizer = JetStreamTokenizer(self.tokenizer_path)
6767

6868
def setup_tiktoken(self):
69-
self.tokenizer_path = "third_party/llama3/tokenizer.model"
69+
self.tokenizer_path = "external_tokenizers/llama3/tokenizer.model"
7070
current_dir = os.path.dirname(__file__)
7171
self.tokenizer_path = os.path.join(current_dir, self.tokenizer_path)
7272
print(f"model_path: {self.tokenizer_path}")

pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
[MAIN]
1010

1111
# Files or directories to be skipped. They should be base names, not paths.
12-
ignore=third_party
12+
ignore=external_tokenizers
1313

1414
# Files or directories matching the regex patterns are skipped. The regex
1515
# matches against base names, not paths.

0 commit comments

Comments
 (0)