Skip to content

Commit 6505339

Browse files
committed
Remove unused VLLM import from train_rl & rename install_tunix_vllm_requirement.sh
1 parent 2d5c026 commit 6505339

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

docs/tutorials/posttraining/rl.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Next, run the following bash script to get all the necessary installations insid
5454
This will take few minutes. Follow along the installation logs and look out for any issues!
5555

5656
```
57-
bash ~/maxtext/src/MaxText/examples/install_tunix_vllm_requirement.sh
57+
bash tools/setup/setup_post_training_requirements.sh
5858
```
5959

6060
Primarily, it installs `vllm-tpu` which is [vllm](https://github.com/vllm-project/vllm) and [tpu-inference](https://github.com/vllm-project/tpu-inference) and thereby providing TPU inference for vLLM, with unified JAX and PyTorch support.

src/MaxText/examples/sft_train_and_evaluate.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,11 @@
2121
2222
## Example command to run on single-host TPU:
2323
```
24-
# Install dependencies in virtual environment
25-
bash setup.sh && bash src/MaxText/examples/install_tunix_vllm_requirement.sh
24+
# Install dependencies in virtual environment:
25+
# https://maxtext.readthedocs.io/en/latest/install_maxtext.html#from-pypi-recommended
26+
27+
# Install post-training dependencies in virtual environment:
28+
bash tools/setup/setup_post_training_requirements.sh
2629
2730
# Environment configurations
2831
export RUN_NAME=$(date +%Y-%m-%d-%H-%M-%S)

src/MaxText/rl/train_rl.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
from tunix.rl.rollout import base_rollout
6565
from tunix.rl.grpo.grpo_learner import GrpoConfig, GrpoLearner
6666
from tunix.sft import metrics_logger, profiler
67-
from vllm.outputs import PoolingRequestOutput # pylint: disable=unused-import
6867

6968
# for vLLM we can skip JAX precompilation with this flag, it makes startup faster
7069
os.environ["SKIP_JAX_PRECOMPILE"] = "1"

src/MaxText/examples/install_tunix_vllm_requirement.sh renamed to tools/setup/setup_post_training_requirements.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# This script installs the dependencies for running GRPO with MaxText+Tunix+vLLM on TPUs
17+
# This script installs the dependencies for running post-training with MaxText+Tunix+vLLM on TPUs
1818

1919
set -e
2020
set -x

0 commit comments

Comments
 (0)