Test unit test

Author: DannyLiCom

src/xpk/commands/cluster.py

@@ -81,6 +81,7 @@
 from ..utils.templates import get_templates_absolute_path
 import shutil
 import os
+import time
 
 CLUSTER_PREHEAT_JINJA_FILE = 'cluster_preheat.yaml.j2'
 
@@ -1481,6 +1482,7 @@ def install_diagon_prerequisites():
   cert_webhook_namespace_name = 'cert-manager'
   # is_running = wait_for_cluster_running(args)
   is_running = wait_for_deployment_ready(deployment_name, namespace_name)
+  time.sleep(30)
   if is_running:
     return_code = install_cert_manager()
     if return_code != 0:
@@ -1489,6 +1491,7 @@ def install_diagon_prerequisites():
     cert_webhook_ready = wait_for_deployment_ready(
         cert_webhook_deployment_name, cert_webhook_namespace_name
     )
+    time.sleep(30)
     if cert_webhook_ready:
 
       webhook_package = 'mldiagnostics-injection-webhook'

src/xpk/commands/cluster_test.py

@@ -250,10 +250,58 @@ def test_run_gke_cluster_create_command_with_gke_version_has_no_autoupgrade_flag
   )
 
 
-def test_cluster_create_args_for_install_diagon_prerequisites(
+def test_install_diagon_prerequisites_commands_executed(
     mocks: _Mocks,
+    mocker,
 ):
+  mock_sleep = mocker.patch('time.sleep', return_value=None)
+
+  mock_wait_ready = mocker.patch(
+      'xpk.commands.cluster.wait_for_deployment_ready', return_value=True
+  )
+  mock_install_cert = mocker.patch(
+      'xpk.commands.cluster.install_cert_manager', return_value=0
+  )
+  mock_download = mocker.patch(
+      'xpk.commands.cluster.download_mldiagnostics_yaml', return_value=0
+  )
+  mock_create_ns = mocker.patch(
+      'xpk.commands.cluster.create_mldiagnostics_namespace', return_value=0
+  )
+  mock_install_yaml = mocker.patch(
+      'xpk.commands.cluster.install_mldiagnostics_yaml', return_value=0
+  )
+  mock_label_ns = mocker.patch(
+      'xpk.commands.cluster.label_default_namespace_mldiagnostics',
+      return_value=0,
+  )
+
+  mocker.patch('os.path.exists', return_value=True)
+  mocker.patch('os.remove')
 
   install_diagon_prerequisites()
 
-  assert mocks.common_print_mock.call_count == 0
+  mock_wait_ready.assert_any_call('kueue-controller-manager', 'kueue-system')
+
+  assert mock_sleep.call_count == 2
+  mock_sleep.assert_any_call(30)
+
+  mock_install_cert.assert_called_once()
+
+  mock_wait_ready.assert_any_call('cert-manager-webhook', 'cert-manager')
+
+  assert mock_download.call_count == 2
+  mock_download.assert_any_call(
+      package_name='mldiagnostics-injection-webhook', version='v0.3.0'
+  )
+  mock_download.assert_any_call(
+      package_name='mldiagnostics-connection-operator', version='v0.3.0'
+  )
+
+  mock_create_ns.assert_called_once()
+
+  assert mock_install_yaml.call_count == 2
+
+  mock_label_ns.assert_called_once()
+
+  assert len(mocks.commands_tester.commands_history) > 0