Telemetry launch (#935)

scaliby · web-flow · commit 40e40bbfdce6 · 2025-12-15T08:04:22.000Z
* feat: telemetry launch

* update goldens
diff --git a/README.md b/README.md
@@ -75,6 +75,20 @@ XPK also supports the following [Google Cloud Storage solutions](./docs/usage/st
   * [Inspector](./docs/usage/inspector.md)
 * [Troubleshooting](./docs/troubleshooting.md)
 
+# Privacy notice
+
+To help improve XPK, feature usage statistics are collected and sent to Google. You can opt-out at any time by executing
+the following shell command:
+
+```shell
+xpk config set send-telemetry <true/false>
+```
+
+XPK telemetry overall is handled in accordance with the [Google Privacy Policy](https://policies.google.com/privacy). When
+you use XPK to interact with or utilize GCP Services, your information is handled in accordance with the
+[Google Cloud Privacy Notice](https://cloud.google.com/terms/cloud-privacy-notice).
+
+
 # Contributing
 
 Please read [`contributing.md`](./docs/contributing.md) for details on our code of conduct, and the process for submitting pull requests to us.
diff --git a/goldens/Cluster_create_private.txt b/goldens/Cluster_create_private.txt
@@ -4,6 +4,8 @@ $ xpk cluster create-pathways --project=golden-project --zone=us-central1-a --cl
 [XPK] Working on golden-project and us-central1-a
 [XPK] Task: `Retrieve available pathways machine types` is implemented by the following command not running since it is a dry run. 
 gcloud compute machine-types list --filter "guestCpus >= 49 AND memoryMb >= 238592 AND zone = 'us-central1-a'" --format="value(name)" --project=golden-project
+[XPK] Task: `Describe reservation` is implemented by the following command not running since it is a dry run. 
+gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a
 [XPK] Task: `Determine server supported GKE versions for default gke version` is implemented by the following command not running since it is a dry run. 
 gcloud container get-server-config --project=golden-project --region=us-central1 --flatten="channels" --filter="channels.channel=RAPID" --format="value(channels.defaultVersion)"
 [XPK] Task: `Determine server supported GKE versions for valid versions` is implemented by the following command not running since it is a dry run. 
diff --git a/goldens/Cluster_create_sub-slicing.txt b/goldens/Cluster_create_sub-slicing.txt
@@ -4,6 +4,8 @@ $ SUB_SLICING_ENABLED=true xpk cluster create --project=golden-project --zone=us
 [XPK] Working on golden-project and us-central1-a
 [XPK] Task: `Get reservation deployment type` is implemented by the following command not running since it is a dry run. 
 gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a --format="value(deploymentType)"
+[XPK] Task: `Describe reservation` is implemented by the following command not running since it is a dry run. 
+gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a
 [XPK] Task: `Determine server supported GKE versions for default gke version` is implemented by the following command not running since it is a dry run. 
 gcloud container get-server-config --project=golden-project --region=us-central1 --flatten="channels" --filter="channels.channel=RAPID" --format="value(channels.defaultVersion)"
 [XPK] Task: `Determine server supported GKE versions for valid versions` is implemented by the following command not running since it is a dry run. 
diff --git a/goldens/Cluster_create_super-slicing.txt b/goldens/Cluster_create_super-slicing.txt
@@ -4,6 +4,8 @@ $ SUPER_SLICING_ENABLED=true xpk cluster create --project=golden-project --zone=
 [XPK] Working on golden-project and us-central1-a
 [XPK] Task: `Get reservation deployment type` is implemented by the following command not running since it is a dry run. 
 gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a --format="value(deploymentType)"
+[XPK] Task: `Describe reservation` is implemented by the following command not running since it is a dry run. 
+gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a
 [XPK] Task: `Determine server supported GKE versions for default gke version` is implemented by the following command not running since it is a dry run. 
 gcloud container get-server-config --project=golden-project --region=us-central1 --flatten="channels" --filter="channels.channel=RAPID" --format="value(channels.defaultVersion)"
 [XPK] Task: `Determine server supported GKE versions for valid versions` is implemented by the following command not running since it is a dry run. 
diff --git a/goldens/Cluster_create_with_gb200-4.txt b/goldens/Cluster_create_with_gb200-4.txt
@@ -2,6 +2,8 @@ $ xpk cluster create --project=golden-project --zone=us-central1-a --cluster=gol
 [XPK] Starting xpk v0.0.0
 [XPK] Starting cluster create for cluster golden-cluster:
 [XPK] Working on golden-project and us-central1-a
+[XPK] Task: `Describe reservation` is implemented by the following command not running since it is a dry run. 
+gcloud beta compute reservations describe golden-reservation --project=golden-project --zone=us-central1-a
 [XPK] Task: `Determine server supported GKE versions for default gke version` is implemented by the following command not running since it is a dry run. 
 gcloud container get-server-config --project=golden-project --region=us-central1 --flatten="channels" --filter="channels.channel=RAPID" --format="value(channels.defaultVersion)"
 [XPK] Task: `Determine server supported GKE versions for valid versions` is implemented by the following command not running since it is a dry run. 
diff --git a/goldens/Cluster_create_with_shared_reservation.txt b/goldens/Cluster_create_with_shared_reservation.txt
@@ -2,6 +2,8 @@ $ xpk cluster create --project=golden-project --zone=us-central1-a --cluster=gol
 [XPK] Starting xpk v0.0.0
 [XPK] Starting cluster create for cluster golden-cluster:
 [XPK] Working on golden-project and us-central1-a
+[XPK] Task: `Describe reservation` is implemented by the following command not running since it is a dry run. 
+gcloud beta compute reservations describe golden-reservation --project=reservation-project --zone=us-central1-a
 [XPK] Task: `Determine server supported GKE versions for default gke version` is implemented by the following command not running since it is a dry run. 
 gcloud container get-server-config --project=golden-project --region=us-central1 --flatten="channels" --filter="channels.channel=RAPID" --format="value(channels.defaultVersion)"
 [XPK] Task: `Determine server supported GKE versions for valid versions` is implemented by the following command not running since it is a dry run. 
diff --git a/src/xpk/utils/feature_flags.py b/src/xpk/utils/feature_flags.py
@@ -28,7 +28,7 @@ def _get_boolean_flag(flag: str, default: bool) -> bool:
 
 class _FeatureFlags:
   SUB_SLICING_ENABLED = _get_boolean_flag("SUB_SLICING_ENABLED", default=False)
-  TELEMETRY_ENABLED = _get_boolean_flag("TELEMETRY_ENABLED", default=False)
+  TELEMETRY_ENABLED = _get_boolean_flag("TELEMETRY_ENABLED", default=True)
   SUPER_SLICING_ENABLED = _get_boolean_flag(
       "SUPER_SLICING_ENABLED", default=False
   )

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ def _get_boolean_flag(flag: str, default: bool) -> bool:`
`28`	`28`
`29`	`29`	`class _FeatureFlags:`
`30`	`30`	`SUB_SLICING_ENABLED = _get_boolean_flag("SUB_SLICING_ENABLED", default=False)`
`31`		`- TELEMETRY_ENABLED = _get_boolean_flag("TELEMETRY_ENABLED", default=False)`
	`31`	`+ TELEMETRY_ENABLED = _get_boolean_flag("TELEMETRY_ENABLED", default=True)`
`32`	`32`	`SUPER_SLICING_ENABLED = _get_boolean_flag(`
`33`	`33`	`"SUPER_SLICING_ENABLED", default=False`
`34`	`34`	`)`