Skip to content

Commit 4f66276

Browse files
authored
Cover sub-slicing-topology in workload_tests (#741)
feat: cover sub-slicing-topology in workload_tests
1 parent 12af0e6 commit 4f66276

File tree

1 file changed

+60
-3
lines changed

1 file changed

+60
-3
lines changed

src/xpk/parser/workload_test.py

Lines changed: 60 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"""
1616

1717
import argparse
18-
from xpk.parser.workload import set_workload_create_parser
18+
from xpk.parser.workload import set_workload_create_parser, set_workload_create_pathways_parser
1919
from ..utils.feature_flags import FeatureFlags
2020
import pytest
2121

@@ -32,7 +32,7 @@ def test_workload_create_sub_slicing_topology_is_hidden_with_flag_off():
3232
set_workload_create_parser(parser)
3333
help_str = parser.format_help()
3434

35-
assert "--sub-slicing" not in help_str
35+
assert "--sub-slicing-topology" not in help_str
3636

3737

3838
def test_workload_create_sub_slicing_topology_is_shown_with_flag_on():
@@ -41,7 +41,7 @@ def test_workload_create_sub_slicing_topology_is_shown_with_flag_on():
4141
set_workload_create_parser(parser)
4242
help_str = parser.format_help()
4343

44-
assert "--sub-slicing" in help_str
44+
assert "--sub-slicing-topology" in help_str
4545

4646

4747
def test_workload_create_sub_slicing_topology_is_none_by_default():
@@ -80,3 +80,60 @@ def test_workload_create_sub_slicing_topology_can_be_set():
8080
])
8181

8282
assert args.sub_slicing_topology is "2x2"
83+
84+
85+
def test_workload_create_pathways_sub_slicing_topology_is_hidden_with_flag_off():
86+
FeatureFlags.SUB_SLICING_ENABLED = False
87+
parser = argparse.ArgumentParser()
88+
89+
set_workload_create_pathways_parser(parser)
90+
help_str = parser.format_help()
91+
92+
assert "--sub-slicing-topology" not in help_str
93+
94+
95+
def test_workload_create_pathways_sub_slicing_topology_is_shown_with_flag_on():
96+
parser = argparse.ArgumentParser()
97+
98+
set_workload_create_pathways_parser(parser)
99+
help_str = parser.format_help()
100+
101+
assert "--sub-slicing-topology" in help_str
102+
103+
104+
def test_workload_create_pathways_sub_slicing_topology_is_none_by_default():
105+
parser = argparse.ArgumentParser()
106+
107+
set_workload_create_pathways_parser(parser)
108+
args = parser.parse_args([
109+
"--cluster",
110+
"test-cluster",
111+
"--command",
112+
"python3",
113+
"--workload",
114+
"test",
115+
"--tpu-type",
116+
"test-tpu",
117+
])
118+
119+
assert args.sub_slicing_topology is None
120+
121+
122+
def test_workload_create_pathways_sub_slicing_topology_can_be_set():
123+
parser = argparse.ArgumentParser()
124+
125+
set_workload_create_pathways_parser(parser)
126+
args = parser.parse_args([
127+
"--cluster",
128+
"test-cluster",
129+
"--command",
130+
"python3",
131+
"--workload",
132+
"test",
133+
"--tpu-type",
134+
"test-tpu",
135+
"--sub-slicing-topology",
136+
"2x2",
137+
])
138+
139+
assert args.sub_slicing_topology is "2x2"

0 commit comments

Comments
 (0)