Skip to content

Commit 5cf4890

Browse files
authored
Implement gcs state bucket parameter passing (#377)
* Pass gcs-state-bucket parameter to delete and create command Signed-off-by: Piotr Pawłowski <[email protected]> --------- Signed-off-by: Piotr Pawłowski <[email protected]>
1 parent 57b32f9 commit 5cf4890

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

.github/workflows/build_tests.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ on:
2020
tpu-type:
2121
description: 'TPU Type'
2222
required: true
23-
default: 'v5p-8'
23+
default: 'v4-8'
2424
type: choice
2525
options:
26-
- v5p-8
27-
- v5litepod-8
26+
- v4-8
2827
push:
2928
branches: ["main","develop"]
3029
pull_request: # By default this runs for types assigned, opened and synchronize.
@@ -67,15 +66,15 @@ jobs:
6766
- name: set zone
6867
id: set-zone
6968
run: |
70-
echo zone=europe-west4-b >> $GITHUB_OUTPUT
69+
echo zone=us-central2-b >> $GITHUB_OUTPUT
7170
- name: set tpu-type
7271
id: set-tpu-type
7372
run: |
74-
echo tpu-type=v5p-8 >> $GITHUB_OUTPUT
73+
echo tpu-type=v4-8 >> $GITHUB_OUTPUT
7574
- name: set location
7675
id: set-location
7776
run: |
78-
echo location=europe-west4 >> $GITHUB_OUTPUT
77+
echo location=us-central2 >> $GITHUB_OUTPUT
7978
install-dependencies:
8079
needs: [set-variables]
8180
runs-on: ubuntu-22.04

.github/workflows/cluster_create.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,4 @@ jobs:
7979
- name: Check xpk installation
8080
run: xpk --help
8181
- name: Create a Pathways-enabled XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
82-
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V5_RESERVATION }}' --enable-gcpfilestore-csi-driver --enable-gcsfuse-csi-driver --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
82+
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --enable-gcpfilestore-csi-driver --enable-gcsfuse-csi-driver --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"

.github/workflows/cluster_private.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
- name: Check xpk installation
7979
run: xpk --help
8080
- name: Create a Pathways-enabled private XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
81-
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V5_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
81+
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}}-private --private --tpu-type=${{inputs.tpu-type}} --num-slices=1 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=4 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
8282
- name: Verify the created cluster is private
8383
run: gcloud container clusters describe ${{inputs.cluster-name}}-private --location=${{inputs.location}} --format="value(privateClusterConfig.enablePrivateNodes)" | grep 'True' || (echo 'The created cluster is not private.' && exit 1)
8484
- name: Delete the cluster created

0 commit comments

Comments
 (0)