Address comments

Author: pajakd

slice/internal/controller/workload_controller.go

@@ -671,7 +671,10 @@ func (r *WorkloadReconciler) validatePartitionCount(
 	log := ctrl.LoggerFrom(ctx)
 	var incorrectSlices []string
 	for _, slice := range slicesToCreate {
-		dims, _ := topology.ParseTopology(slice.Spec.Topology)
+		dims, err := topology.ParseTopologyV7(slice.Spec.Topology)
+		if err != nil {
+			return err
+		}
 		numberOfCubesFromTopology := dims[0] * dims[1] * dims[2] / core.TPUsPerCube
 		if int(numberOfCubesFromTopology) != len(slice.Spec.PartitionIds) {
 			incorrectSlices = append(incorrectSlices, slice.Name)

slice/internal/topology/topology.go

@@ -58,7 +58,7 @@ func ParseAssignment(topologyAssignment *kueue.TopologyAssignment, nodes map[str
 	return parsedAssignment
 }
 
-func ParseTopology(tpuTopology string) ([]int64, error) {
+func ParseTopologyV7(tpuTopology string) ([]int64, error) {
 	dimensions := strings.Split(tpuTopology, "x")
 	if len(dimensions) != 3 {
 		return nil, fmt.Errorf("invalid topology format: %s, expected 3 dimensions", tpuTopology)

slice/internal/topology/topology_test.go

@@ -83,7 +83,7 @@ func TestParseTopology(t *testing.T) {
 
 	for name, tc := range testCases {
 		t.Run(name, func(t *testing.T) {
-			dims, err := ParseTopology(tc.topology)
+			dims, err := ParseTopologyV7(tc.topology)
 			if (err != nil) != tc.wantErr {
 				t.Errorf("parseTopology() error = %v, wantErr %v", err, tc.wantErr)
 				return

slice/internal/webhooks/jobset_webhook.go

@@ -135,7 +135,7 @@ func annotateReplicatedJobWithSliceHealth(rj *v1alpha2.ReplicatedJob) {
 }
 
 func (r *JobSetWebhook) podSetSliceSize(tpuTopology string, parallelism int32) (int64, error) {
-	dims, err := topology.ParseTopology(tpuTopology)
+	dims, err := topology.ParseTopologyV7(tpuTopology)
 	if err != nil {
 		return 0, err
 	}