fixed type absence case

Author: MarcusTantakoun

l2p/domain_builder.py

@@ -289,32 +289,28 @@ def extract_pddl_action(
                                     llm_response, syntax_validator.unsupported_keywords
                                 )
                             )
-                        elif e == "invalid_param_types":
+                        elif e == "invalid_param_types" and types:
                             validation_info = syntax_validator.validate_params(
                                 action["params"], types
                             )
-                        elif e == "invalid_predicate_name":
+                        elif e == "invalid_predicate_name" and types:
                             validation_info = (
                                 syntax_validator.validate_types_predicates(
                                     new_predicates, types
                                 )
                             )
-                        elif e == "invalid_predicate_format":
+                        elif e == "invalid_predicate_format" and types:
                             validation_info = (
                                 syntax_validator.validate_format_predicates(
                                     predicates, types
                                 )
                             )
-                        elif e == "invalid_predicate_usage":
+                        elif e == "invalid_predicate_usage" and types:
                             validation_info = (
                                 syntax_validator.validate_usage_predicates(
                                     llm_response, predicates, types
                                 )
                             )
-                        else:
-                            raise NotImplementedError(
-                                f"Validation type '{e}' is not implemented."
-                            )
 
                         if not validation_info[0]:
                             return action, new_predicates, llm_response, validation_info

l2p/utils/pddl_validator.py

@@ -46,12 +46,15 @@ def validate_params(
         # If no types are defined, inform the user and check for parameter types
         if not types:
             for param_name, param_type in parameters.items():
-                if param_type is not None:
+                if param_type is not None and param_type != "":
                     feedback_msg = (
                         f'The parameter `{param_name}` has an object type `{param_type}` '
                         'while no types are defined. Please remove the object type from this parameter.'
                     )
                     return False, feedback_msg
+            
+            # if all parameter names do not contain a type
+            return True, "PASS: All parameters are valid."
 
         # Otherwise, check that parameter types are valid in the given types
         for param_name, param_type in parameters.items():