Refine the type definitions

Author: aiqlcom

package-lock.json

@@ -74,6 +74,7 @@
     "@eslint/eslintrc": "^3.3.1",
     "@eslint/js": "^9.36.0",
     "@playwright/test": "^1.55.1",
+    "@types/lodash": "^4.17.20",
     "@typescript-eslint/eslint-plugin": "^8.44.1",
     "@typescript-eslint/parser": "^8.44.1",
     "@vitejs/plugin-vue": "^6.0.1",

package.json

@@ -28,6 +28,8 @@ import { commandSelectionInvoke, mcpServersProcessCallback } from './index'
 import { getCachedText } from './aid/utils'
 import { McpClientResponse, CommandResponse, McpInitResponse } from './types'
 
+import { IpcFileTransferRequest, IpcFileTransferResponse } from '@/types/ipc'
+
 const handlerRegistry = new Map<string, Function>()
 
 interface ManifestResponse {
@@ -189,28 +191,39 @@ export default class IPCs {
       return dialogResult
     })
 
-    ipcMain.on('msgFileTransferRequest', async (event: IpcMainEvent, { name, data }) => {
-      try {
-        const buffer = Buffer.from(data)
-        const saveOption = Constants.getDxtSource(name)
-        const filePath = saveOption.mcpbPath
-        const dirPath = saveOption.outputDir
-        if (!existsSync(dirPath)) {
-          mkdirSync(dirPath, { recursive: true })
+    ipcMain.on(
+      'msgFileTransferRequest',
+      async (event: IpcMainEvent, { name, data }: IpcFileTransferRequest) => {
+        try {
+          const buffer = Buffer.from(data)
+          const saveOption = Constants.getDxtSource(name)
+          const filePath = saveOption.mcpbPath
+          const dirPath = saveOption.outputDir
+          if (!existsSync(dirPath)) {
+            mkdirSync(dirPath, { recursive: true })
+          }
+          console.log('MCP bundle to be saved in: ', filePath)
+
+          writeFileSync(filePath, buffer, { encoding: null })
+
+          console.log(saveOption)
+          await unpackDxt(saveOption)
+          // console.log(getManifest(dirPath))
+
+          event.reply('msgFileTransferResponse', {
+            name,
+            success: true,
+            path: saveOption.outputDir
+          } as IpcFileTransferResponse)
+        } catch (err) {
+          event.reply('msgFileTransferResponse', {
+            name,
+            success: false,
+            reason: err.message
+          } as IpcFileTransferResponse)
         }
-        console.log('MCP bundle to be saved in: ', filePath)
-
-        writeFileSync(filePath, buffer, { encoding: null })
-
-        console.log(saveOption)
-        await unpackDxt(saveOption)
-        // console.log(getManifest(dirPath))
-
-        event.reply('msgFileTransferResponse', { name, success: true, path: saveOption.outputDir })
-      } catch (err) {
-        event.reply('msgFileTransferResponse', { name, success: false, reason: err.message })
       }
-    })
+    )
 
     ipcMain.on(
       'msgCommandSelectionResult',

src/main/IPCs.ts

@@ -32,9 +32,9 @@ const props = defineProps({
 const { modelValue: metadata } = props
 const { config: manifest } = metadata
 
-const showPassword = reactive({})
+const showPassword = reactive<Record<string, boolean>>({})
 
-function toggleShowPassword(key) {
+function toggleShowPassword(key: string) {
   showPassword[key] = !showPassword[key]
 }
 

src/renderer/components/common/ConfigDxtCard.vue

@@ -8,7 +8,7 @@ const stdioStore = useStdioStore()
 
 const editDialog = ref(false)
 
-const showPassword = reactive({})
+const showPassword = reactive<Record<string, boolean>>({})
 
 const props = defineProps({
   modelValue: {

src/renderer/components/common/ConfigStdioCard.vue

@@ -1,38 +1,48 @@
 import { defineStore } from 'pinia'
 
+type SnackbarType = 'error' | 'success' | 'info' | 'warning' | 'unknown'
+
+interface SnackbarState {
+  isShow: boolean
+  message: string
+  type: SnackbarType
+}
+
 export const useSnackbarStore = defineStore('snackbarStore', {
-  state: () => ({
-    isShow: false,
-    message: '',
-    type: ''
-  }),
+  state: () =>
+    ({
+      isShow: false,
+      message: '',
+      type: 'unknown'
+    }) as SnackbarState,
 
   actions: {
-    showMessage(message, type = '') {
+    showMessage(message: string, type: SnackbarType = 'unknown') {
       console.log(message)
       this.isShow = true
       this.message = message
       this.type = type
     },
 
-    showErrorMessage(message) {
+    showErrorMessage(message: string) {
       this.showMessage(message, 'error')
     },
-    showSuccessMessage(message) {
+    showSuccessMessage(message: string) {
       this.showMessage(message, 'success')
     },
-    showInfoMessage(message) {
+    showInfoMessage(message: string) {
       this.showMessage(message, 'info')
     },
-    showWarningMessage(message) {
+    showWarningMessage(message: string) {
       this.showMessage(message, 'warning')
     },
     getIcon() {
       const icon = {
         info: 'mdi-information',
         success: 'mdi-check-circle',
         error: 'mdi-alert-circle',
-        warning: 'mdi-alert'
+        warning: 'mdi-alert',
+        unknown: 'mdi-help-circle-outline'
       }
 
       return icon[this.type]

src/renderer/store/snackbar.ts

@@ -9,7 +9,9 @@ import {
   SamplingResponse,
   ElicitResponse,
   CommandResponse,
-  McpInitResponse
+  McpInitResponse,
+  IpcFileTransferRequest,
+  IpcFileTransferResponse
 } from '@/types/ipc'
 
 function isValidValue(value: any): boolean {
@@ -119,19 +121,22 @@ export const ElicitationTransfer = {
 }
 
 class File {
-  static async sendFileToMainRequest(file: { name: string; data: ArrayBuffer }): Promise<void> {
+  static async sendFileToMainRequest(file: IpcFileTransferRequest): Promise<void> {
     await window.mainApi.send('msgFileTransferRequest', file)
   }
-  static async sendFileToMainResponse(count: number): Promise<void> {
-    const results: any = []
+  static async sendFileToMainResponse(count: number): Promise<IpcFileTransferResponse[]> {
+    const results: IpcFileTransferResponse[] = []
     let completedCount = 0
-    window.mainApi.on('msgFileTransferResponse', (_event, result) => {
-      results.push(result)
-      completedCount++
-      if (completedCount === count) {
-        console.log('All done', results)
+    window.mainApi.on(
+      'msgFileTransferResponse',
+      (_event: Event, result: IpcFileTransferResponse) => {
+        results.push(result)
+        completedCount++
+        if (completedCount === count) {
+          console.log('All done', results)
+        }
       }
-    })
+    )
     return results
   }
 }

src/renderer/utils/index.ts

@@ -44,3 +44,9 @@ export type IpcMcpInitRequest = {
 }
 
 export type IpcMcpInitRequestCallback = (_event: Event, _progress: IpcMcpInitRequest) => void
+
+export type IpcFileTransferRequest = { name: string; data: ArrayBuffer }
+
+export type IpcFileTransferResponse =
+  | { name: string; success: false; reason: string }
+  | { name; success: true; path: string }