Improve error handling, fix compatibility issues, add test coverage #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace bare except clauses with specific exception types - Fix missing linear_schedule function import - Update pandas fillna to modern API - Complete gym to gymnasium migration - Add comprehensive StockTradingEnv test suite
- Explains all 4 bugs fixed with code examples - Provides step-by-step test execution instructions - Documents test coverage details for each test class - Includes manual verification steps - Shows coverage metrics improvements
- Automated setup script for test environment - Quick start guide with dependency workarounds - Documents known dependency conflicts with alpaca-trade-api - Provides multiple options for running tests
for more information, see https://pre-commit.ci
Remove unused local variables in test_stocktrading.py to resolve F841 flake8 errors. All pre-commit hooks now pass for PR files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready in PR_SUBMISSION.txt
This PR improves code quality and reliability across FinRL. It removes bare exception handlers that previously hid critical failures (including in paper trading), restores a missing import needed for hyperparameter optimization, and updates deprecated pandas syntax for pandas 2.0+ compatibility. It also completes the migration from gym to gymnasium.
The PR adds 31 targeted tests for StockTradingEnv, increasing coverage by 64%. All updates remain backwards compatible and include documentation to help maintainers validate the fixes and run the test suite.