Skip to content

Commit 27c68bd

Browse files
committed
fix: resolve final linting issues
- Fix shellcheck warning in stop.sh by using underscore for unused loop variable - Fix YAML line length issues in release workflow by breaking go build commands further - Remove extra blank line in release workflow YAML
1 parent 32c69be commit 27c68bd

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,23 +64,28 @@ jobs:
6464
GOOS=linux GOARCH=amd64 go build \
6565
-ldflags \
6666
"-X github.com/maximilien/maestro-mcp/src/pkg/config.Version=$VERSION" \
67-
-o release/maestro-mcp-linux-amd64 ./src/main.go
67+
-o release/maestro-mcp-linux-amd64 \
68+
./src/main.go
6869
GOOS=linux GOARCH=arm64 go build \
6970
-ldflags \
7071
"-X github.com/maximilien/maestro-mcp/src/pkg/config.Version=$VERSION" \
71-
-o release/maestro-mcp-linux-arm64 ./src/main.go
72+
-o release/maestro-mcp-linux-arm64 \
73+
./src/main.go
7274
GOOS=darwin GOARCH=amd64 go build \
7375
-ldflags \
7476
"-X github.com/maximilien/maestro-mcp/src/pkg/config.Version=$VERSION" \
75-
-o release/maestro-mcp-darwin-amd64 ./src/main.go
77+
-o release/maestro-mcp-darwin-amd64 \
78+
./src/main.go
7679
GOOS=darwin GOARCH=arm64 go build \
7780
-ldflags \
7881
"-X github.com/maximilien/maestro-mcp/src/pkg/config.Version=$VERSION" \
79-
-o release/maestro-mcp-darwin-arm64 ./src/main.go
82+
-o release/maestro-mcp-darwin-arm64 \
83+
./src/main.go
8084
GOOS=windows GOARCH=amd64 go build \
8185
-ldflags \
8286
"-X github.com/maximilien/maestro-mcp/src/pkg/config.Version=$VERSION" \
83-
-o release/maestro-mcp-windows-amd64.exe ./src/main.go
87+
-o release/maestro-mcp-windows-amd64.exe \
88+
./src/main.go
8489
8590
# Make binaries executable
8691
chmod +x release/maestro-mcp-linux-amd64
@@ -158,7 +163,6 @@ jobs:
158163
env:
159164
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
160165

161-
- name: Upload build artifacts
162166
uses: actions/upload-artifact@v4
163167
with:
164168
name: release-binaries-${{ steps.version.outputs.version }}

stop.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ stop_server() {
100100
print_status "Sent SIGTERM signal to server..."
101101

102102
# Wait for graceful shutdown
103-
for i in {1..30}; do
103+
for _ in {1..30}; do
104104
if ! ps -p "$PID" > /dev/null 2>&1; then
105105
print_success "Server stopped gracefully"
106106
rm -f maestro-mcp.pid

0 commit comments

Comments
 (0)