Skip to content

Commit c91eb9c

Browse files
authored
Remove the llvm-header-guard check for clang-tidy (#915)
* Remove the llvm-header-guard check for clang-tidy, seems buggy See llvm/llvm-project#164417 * Add a few NOLINT in unittest.cpp --------- Co-authored-by: Juan Miguel Carceller <[email protected]>
1 parent 8b7407e commit c91eb9c

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

.clang-tidy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Checks: -*,
44
clang-diagnostic-*,
55
misc-string-compare,
66
misc-uniqueptr-reset-release,
7-
llvm-header-guard,
87
modernize-deprecated-headers,
98
modernize-use-bool-literals,
109
modernize-use-equals-delete,

tests/unittests/unittest.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,10 +1136,10 @@ TEST_CASE("GenericParameters", "[generic-parameters]") {
11361136
auto gp = podio::GenericParameters{};
11371137

11381138
gp.set("anInt", 42);
1139-
REQUIRE(*gp.get<int>("anInt") == 42);
1139+
REQUIRE(*gp.get<int>("anInt") == 42); // NOLINT
11401140
// Make sure that resetting a value with the same key works
11411141
gp.set("anInt", -42);
1142-
REQUIRE(*gp.get<int>("anInt") == -42);
1142+
REQUIRE(*gp.get<int>("anInt") == -42); // NOLINT
11431143

11441144
// Make sure that passing a string literal is converted to a string on the fly
11451145
gp.set("aString", "const char initialized");
@@ -1223,11 +1223,11 @@ TEST_CASE("GenericParameters constructors", "[generic-parameters]") {
12231223

12241224
SECTION("Copy constructor") {
12251225
auto copiedParams = originalParams;
1226-
REQUIRE(*copiedParams.get<int>("int") == 42);
1227-
REQUIRE(copiedParams.get<std::vector<int>>("ints").value()[1] == 2);
1228-
REQUIRE(*copiedParams.get<float>("float") == 3.14f);
1229-
REQUIRE(*copiedParams.get<double>("double") == 2 * 3.14);
1230-
REQUIRE(copiedParams.get<std::vector<std::string>>("strings").value()[0] == "one");
1226+
REQUIRE(*copiedParams.get<int>("int") == 42); // NOLINT
1227+
REQUIRE(copiedParams.get<std::vector<int>>("ints").value()[1] == 2); // NOLINT
1228+
REQUIRE(*copiedParams.get<float>("float") == 3.14f); // NOLINT
1229+
REQUIRE(*copiedParams.get<double>("double") == 2 * 3.14); // NOLINT
1230+
REQUIRE(copiedParams.get<std::vector<std::string>>("strings").value()[0] == "one"); // NOLINT
12311231

12321232
// Make sure these are truly independent copies now
12331233
copiedParams.set("anotherDouble", 1.2345);

0 commit comments

Comments
 (0)