This repository was archived by the owner on Jul 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Redact sensitive information from logs #154
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestup-for-grabsStand-alone tasks that are well described, and should take no longer than a few nights of workStand-alone tasks that are well described, and should take no longer than a few nights of work
Description
Is your feature request related to a problem? Please describe.
There is no log redaction, and part of the bug report process includes users posting their logs. It's possible for users to accidentally leak their access token if it's ever mistakenly printed to console and they report a bug.
Describe the solution you'd like
Logs should be intercepted, either by overwriting the window.console object or by using a different logger that supports redaction.
Describe alternatives you've considered
- We could ask users to scan their logs before submitting them to remove any sensitive data, but that is likely too high of an ask for bug reports.
- We could remove all logs, but that would make bug reports a lot harder to resolve.
- We could hide the token in a procedure rather than returning a string, but it's still possible that the procedure could leak the token. This also doesn't support other kinds of redaction, such as their username.
- We could develop a log preprocessor for bug reports, but that's not something that GitHub natively supports and would require significant new infrastructure.
Additional context
See the wiki for getting started.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestup-for-grabsStand-alone tasks that are well described, and should take no longer than a few nights of workStand-alone tasks that are well described, and should take no longer than a few nights of work