Proof of concept #133
Replies: 9 comments 58 replies
-
|
|
Beta Was this translation helpful? Give feedback.
-
// ==WindhawkMod==
// @id restore-uwp-buttons
// @name Restore UWP Buttons
// @description This mod restores uwp caption buttons
// @version 0.2
// @author ALTaleX
// @github https://github.com/ALTaleX531
// @include dwm.exe
// ==/WindhawkMod==
// ==WindhawkModReadme==
/*
# aaaaa
*/
// ==/WindhawkModReadme==
#include <libloaderapi.h>
#include <windef.h>
#include <windhawk_utils.h>
#include <winnt.h>
bool (STDMETHODCALLTYPE*CWindowData_IsImmersiveWindow_Original)(void* This);
bool STDMETHODCALLTYPE MyCWindowData_IsImmersiveWindow(void* This)
{
return CWindowData_IsImmersiveWindow_Original(This);
}
void (STDMETHODCALLTYPE*CTopLevelWindow_EnsureNonClientAreaButton_Original)(void* This, int index);
void STDMETHODCALLTYPE MyCTopLevelWindow_EnsureNonClientAreaButton(void* This, int index)
{
const auto v = *(DWORD*)(ULONG_PTR(This) + 592);
const auto data = ((void**)(This))[91];
if (CWindowData_IsImmersiveWindow_Original(data))
{
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x100;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x1000;
*(DWORD*)(ULONG_PTR(This) + 592) |= 8;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x200;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x2000;
*(DWORD*)(ULONG_PTR(This) + 592) |= 9;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x400;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x4000;
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x14;
// caption
*(DWORD*)(ULONG_PTR(This) + 592) |= 0x10080;
}
CTopLevelWindow_EnsureNonClientAreaButton_Original(This, index);
*(DWORD*)(ULONG_PTR(This) + 592) = v;
}
BOOL Wh_ModInit(void)
{
WindhawkUtils::SYMBOL_HOOK hooks[] = {
{
{
L"private: long __cdecl CTopLevelWindow::EnsureNonClientAreaButton(enum CTopLevelWindow::ButtonType)"
},
(void**)&CTopLevelWindow_EnsureNonClientAreaButton_Original,
(void*)MyCTopLevelWindow_EnsureNonClientAreaButton,
false
},
{
{
L"public: bool __cdecl CWindowData::IsImmersiveWindow(void)const "
},
(void**)&CWindowData_IsImmersiveWindow_Original,
(void*)MyCWindowData_IsImmersiveWindow,
false
}
};
if (!WindhawkUtils::HookSymbols(GetModuleHandleW(L"udwm.dll"), hooks, ARRAYSIZE(hooks))){
Wh_Log(L"Cannot hook uDWM.dll");
return FALSE;
}
return TRUE;
}Just in case anyone needs it |
Beta Was this translation helpful? Give feedback.
-
Beat me to it by about 45 seconds again 😅 |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
It's not an awm bug, the uwp close button appears to have a flag indicating it's the only titlebar button, making it use the wrong button outline. This is very noticeable with the aero10 theme.
I will leave it to you. |
Beta Was this translation helpful? Give feedback.
-
|
This looks amazing! Would Aero Borders on Modern Apps also be possible on Windows 11? |
Beta Was this translation helpful? Give feedback.
-
|
This has always been possible, just not perfect. Most modern UWPs tend to customize their titlebars to override the one rendered by ApplicationFrameHost, which is why glass8's ModernFrame feature breaks. Another way to implement aero borders is to force the removal of ApplicationFrameHost's titlebar and use the native titlebar, however this may cause the app to appear to have two titlebars. At the moment, I have no plans to go any further, so I'm sharing what I've already found to see if anyone wants to go into it. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
I didn’t know it existed either, Odd that they only added captionheight not with captionwidth or i am missing something. When i mention caption button resizing, I usually refer to the buttons size being like windows vista up to windows 8.x (same size It seems) both height and width. |
Beta Was this translation helpful? Give feedback.
-
|
I know what you're talking about. Unfortunately, this is a feature I don't intend to introduce in OpenGlass. I'll probably add it to DWMBlurGlass when I rewrite it. |
Beta Was this translation helpful? Give feedback.
-
|
No problem, If you would share the build of openglass with text glow (text glow on your latest screenshot), lmk. |
Beta Was this translation helpful? Give feedback.
-
Oh hey, finally. Someone has got your back, Take a look at the very recent pull request from the user who introduced the feature so you don’t have to try put effort into adding it. I finally can use openglass alone not with dwmblurglass, probably even on windows 10 too. |
Beta Was this translation helpful? Give feedback.
-
I will probably release a beta after the merge. |
Beta Was this translation helpful? Give feedback.
-
|
This is a beta version, and since I've introduced a lot of new improvements and fixes, I'm not sure it's stable. Therefore, I decided to do a small test before pushing the code and releasing the official version. What's Changed
NoticeThis version is for testing purposes only and redistribution is not allowed. Additionally, this version will display a watermark in the bottom right corner of your desktop, which is temporary and will not appear in the final release. |
Beta Was this translation helpful? Give feedback.
-
|
Another thing that may have existed before, context menus still have modern borders when using
|
Beta Was this translation helpful? Give feedback.
-
I set the value manually in the registry and it seems to work fine, thanks! It seems that when you set the color as (0,0,0) AeroGlassGUI just deletes the registry key, causing the unwanted behavior. |
Beta Was this translation helpful? Give feedback.
-
OpenGlass/OpenGlass/GlassFrameHandler.cpp Lines 830 to 834 in 836079d This is actually intentional, so it only works for windows that have a titlebar. I think over intervention may cause some of the UI to display incorrectly, and OpenGlass should not care about parts that are not related to its own main features. |
Beta Was this translation helpful? Give feedback.
-
It also seems like the registry key is deleted whenever I restart my system, not sure why that is happening. I'll try using rgb(1,1,1) and see if it also gets deleted. |
Beta Was this translation helpful? Give feedback.
-
It could be that every time you start AeroGlassGUI it automatically deletes the keys that it thinks are the same as the default values, btw the registry is read only for OpenGlass. |
Beta Was this translation helpful? Give feedback.
-
|
I can confirm disablemodernborders is now fixed and the text glow looks very great, No issues for me so far. |
Beta Was this translation helpful? Give feedback.
-
|
CenterCaption = 2 is removed from this build? |
Beta Was this translation helpful? Give feedback.
-
|
It did get removed, because almost nobody uses it and win11 doesn't support that alignment, so it was removed to ensure consistency of functionality. |
Beta Was this translation helpful? Give feedback.
-
|
@ALTaleX531 What was CenterCaption = 2? |
Beta Was this translation helpful? Give feedback.
-
It was the proper windows 8 centering option iirc |
Beta Was this translation helpful? Give feedback.
-
Announcing OpenGlass with D3D Glass Renderer
It's normal to have bugs or visual glitches in this build, but I'm more interested in feedback about glass performance. |
Beta Was this translation helpful? Give feedback.
-
|
@ALTaleX531 Here is a recording. It is a bit hard to see, but when I am not holding shift it runs at around 30-45fps and when I am holding shift it runs at my monitors max refresh rate. https://litter.catbox.moe/nw8hxvlcxoazincp.mp4 (Link is good for 3 days) |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I can reproduce it, kind of weird, the GPU usage is relatively low but the framerate is severely dropped. It could be that D3D is conflicting with D2D since DWM uses D2D for almost all of its rendering pipeline, I'll look into it. |
Beta Was this translation helpful? Give feedback.
-
|
I figured out, it's not that D3D is conflicting with D2D, it's that tessellation is taking too long (tessellation is a step that converts the blur region to a collection of triangle vertices), only if |
Beta Was this translation helpful? Give feedback.
-
|
Any updates on this/a way to disable the watermark? lol |
Beta Was this translation helpful? Give feedback.
-
implemented in Build legacy v2.2.0.2043 |
Beta Was this translation helpful? Give feedback.
-
|
Btw, the blur algorithm is currently an exact replica of Windows 7, but I think it could use a more efficient algorithm, do you guys think it should continue to be optimized? |
Beta Was this translation helpful? Give feedback.
-
Unfortunately the blur implementation makes almost no difference, the only optimization for Windows 8 is just using HLSL minimum precision. Vista uses D3D9's StretchRect, which copies to a half-resolution texture, blurs it horizontally and vertically, and then draws it to the screen with the foreground color. 7 uses D3D11, which doesn't have a StretchRect anymore, and can't copy to a different resolution texture, but the back buffer can also be read as a texture. The result becomes doing a horizontal blur directly from the back buffer to a texture that's only half as large horizontally, and then doing a vertical blur to a texture that's half as large in resolution. On early hardware, the 7 approach would be slower. Because the first time you read in the shader it's full resolution. By the end of the day it doesn't make a difference anymore. As for the blur implementation of Windows 11, surprisingly it seems slower than 7. For the same blur radius of 3, 7 takes only 8 samples for one pass, while 11 takes 10. I probably won't optimize it, 7‘s algorithm looks like the most efficient one already. |
Beta Was this translation helpful? Give feedback.
-
So it didn't just "feel" faster on Vista, it actually was? It's strange that D3D11 would cut features that yielded improved performance in some applications, but I don't know exactly where else the blur formula would have been used outside of Aero. I could understand removing it if it was just that niche application. |
Beta Was this translation helpful? Give feedback.
-
A big part of this comes from the revolution in the rendering pipeline, but D3D11 is actually far faster than D3D9 most of the time.
Actually that's not very possible, unless you're using hardware made before the 2010s. |
Beta Was this translation helpful? Give feedback.
-
Yes, I did run Vista and 7 on an older Optiplex (circa 2012, 2013) up until just last year when I was forced to move to 10. The performance difference was very noticeable. On my main PC, I have Vista, 7 and 10 installed, but Vista doesn't have drivers for the RTX 3060 - 7 does and can run Aero, so I can't make an apples to apples comparison on modern hardware - not that it matters because it is way overkill and no real difference would actually be felt between Vista and 7. But it was certainly felt on the older Optiplex. Generally, Vista felt a lot faster than 7 overall, not considering Aero, but I do suspect that the opaque windows when maximized on Vista was an optimization of the time. Though, the PC I had in the Vista-era did handle Aero just fine. It did have a beefier graphics card though. I can't remember what it was, but it did great. I never had the same problems everyone else did with Vista and I stuck with it by the time everybody else moved to 7 and thus, skipped 7 almost entirely. |
Beta Was this translation helpful? Give feedback.
-
I'm skeptical about Vista being much faster than Windows 7. From what I've seen, Vista does a very poor job of resource management, with hardware acceleration for GDI completely removed, and window contents requiring a copy to be saved in both RAM and VRAM, accompanied by frequent video memory readbacks and uploads to video memory. These show that even if Vista's blur is faster, its advantages are completely wiped out by its own poor resource management. Your feeling that Vista is faster may be more psychological; it is, after all, an OS with which you are much more familiar.
You're right, the hardware at that time couldn't afford the performance loss from fullscreen blur, and the occlusion algorithms in Vista were worse than 7 at that time. |
Beta Was this translation helpful? Give feedback.
-
I feel like it being an exact replica is probably actually a good thing, seeing just how many users of your software prefer accuracy.
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Here are some interesting experiments on DWM.
Beta Was this translation helpful? Give feedback.
All reactions