Skip to content

Commit a86d271

Browse files
authored
make pp_data_dir configurable and add pp_vis dependencies (#183)
1 parent 653ad38 commit a86d271

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

primus/modules/trainer/megatron/trainer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1732,7 +1732,7 @@ def get_e2e_base_metrics():
17321732
if args.dump_pp_data:
17331733
from .utils import dump_pp_data
17341734

1735-
pp_data_dir = "output/pp_data"
1735+
pp_data_dir = os.environ.get("DUMP_PP_DIR", "output/pp_data")
17361736
dump_pp_data(args, get_num_microbatches(), pp_data_dir)
17371737
log_rank_0(f"pp schedule data dumped to {pp_data_dir}")
17381738

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
numpy
22
matplotlib
3+
tornado

0 commit comments

Comments
 (0)