Skip to content

Commit 202ec52

Browse files
authored
doc: Update branching model (#2816)
1 parent 311826c commit 202ec52

File tree

6 files changed

+26
-20
lines changed

6 files changed

+26
-20
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ or [`help wanted`](https://github.com/AMICI-dev/AMICI/issues?q=is%3Aissue+is%3Ao
99
For other ideas or questions, just post an issue.
1010

1111
For code contributions, please read our
12-
[developer's guide](https://amici.readthedocs.io/en/develop/development.html) first.
12+
[developer's guide](https://amici.readthedocs.io/en/main/development.html) first.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,22 +80,22 @@ is then used for model simulation.
8080
The AMICI source code is available at https://github.com/AMICI-dev/AMICI/.
8181
To install AMICI, first read the installation instructions for
8282
[Python](https://amici.readthedocs.io/en/latest/python_installation.html),
83-
[C++](https://amici.readthedocs.io/en/develop/cpp_installation.html) or
84-
[Matlab](https://amici.readthedocs.io/en/develop/matlab_installation.html).
83+
[C++](https://amici.readthedocs.io/en/main/cpp_installation.html) or
84+
[Matlab](https://amici.readthedocs.io/en/main/matlab_installation.html).
8585
There are also instructions for using AMICI inside
8686
[containers](https://github.com/AMICI-dev/AMICI/tree/master/container).
8787

8888
To get you started with Python-AMICI, the best way might be checking out this
8989
[Jupyter notebook](https://github.com/AMICI-dev/AMICI/blob/master/doc/examples/getting_started/GettingStarted.ipynb)
90-
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/AMICI-dev/AMICI/develop?labpath=doc%2Fexamples%2Fgetting_started%2FGettingStarted.ipynb).
90+
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/AMICI-dev/AMICI/main?labpath=doc%2Fexamples%2Fgetting_started%2FGettingStarted.ipynb).
9191

9292
To get started with Matlab-AMICI, various examples are available
9393
in [matlab/examples/](https://github.com/AMICI-dev/AMICI/tree/master/matlab/examples).
9494

9595
Comprehensive documentation is available at
9696
[https://amici.readthedocs.io/en/latest/](https://amici.readthedocs.io/en/latest/).
9797

98-
Any [contributions](https://amici.readthedocs.io/en/develop/CONTRIBUTING.html)
98+
Any [contributions](https://amici.readthedocs.io/en/main/CONTRIBUTING.html)
9999
to AMICI are welcome (code, bug reports, suggestions for improvements, ...).
100100

101101

doc/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def install_doxygen():
154154
release = version
155155

156156
project = "AMICI"
157-
copyright = "2020, The AMICI developers"
157+
copyright = "2015-2025, The AMICI developers"
158158
author = "The AMICI developers"
159159
title = "AMICI Documentation"
160160

doc/development.rst

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ relevant to regular users.
77
Branches / releases
88
-------------------
99

10-
AMICI roughly follows the
11-
`GitFlow <https://nvie.com/posts/a-successful-git-branching-model/>`__.
12-
All new contributions are merged into ``develop``. These changes are
13-
regularly merged into ``master`` as new releases. For release versioning
14-
we are trying to follow `semantic versioning <https://semver.org/>`__.
10+
For AMICI, we mostly do `trunk-based development <https://trunkbaseddevelopment.com/>`__.
11+
All new contributions are merged into ``main`` after passing the test suite
12+
and code review. Releases are usually created directly from ``main``.
1513
New releases are created on GitHub and are automatically deployed to
1614
`Zenodo <https://doi.org/10.5281/zenodo.597928>`__ for
1715
archiving and to obtain a digital object identifier (DOI) to make them
@@ -20,8 +18,7 @@ automatically create and deploy a new release on
2018
`PyPI <https://pypi.org/project/amici/>`__.
2119

2220
We try to keep a clean git history. Therefore, feature pull requests are
23-
squash-merged to ``develop``. Merging of release branches to master is
24-
done via merge commits.
21+
squash-merged to ``main``.
2522

2623
When starting to work on some issue
2724
-----------------------------------
@@ -44,12 +41,17 @@ process described below:
4441
`AMICI's license conditions <https://github.com/AMICI-dev/AMICI/blob/master/LICENSE.md>`__.
4542
By opening a pull requests you confirm us that you do agree.
4643

47-
- Start a new branch from ``develop`` (on your fork, or at the main
44+
- Start a new branch from ``main`` (on your fork, or at the main
4845
repository if you have access)
4946

5047
- Implement your changes
5148

52-
- Submit a pull request to the ``develop`` branch
49+
- Update ``CHANGELOG.md`` with a short description of your changes.
50+
This can be omitted for small changes that do not affect the
51+
functionality of AMICI, e.g. fixing typos or formatting issues,
52+
private refactoring, ...
53+
54+
- Submit a pull request to the ``main`` branch
5355

5456
- Ensure all tests pass
5557

@@ -117,7 +119,7 @@ Python
117119
C++
118120
^^^
119121

120-
- We use C++17
122+
- We use C++20
121123

122124
- We want to maintain compatibility with g++, clang, and the Intel C++
123125
compiler
@@ -126,10 +128,14 @@ C++
126128
be invoked by ``make clang-format cmake-format`` from the CMake build
127129
directory.
128130

131+
- For new code, we use `Google's C++ style guide <https://google.github.io/styleguide/cppguide.html>`__ as a reference.
132+
133+
129134
Matlab
130135
^^^^^^
131136

132-
*To be defined*
137+
No new Matlab code should be added to AMICI
138+
(see `#2727 <https://github.com/AMICI-dev/AMICI/issues/2727>`__).
133139

134140
Further topics
135141
--------------

doc/python_examples.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Examples
44
Various example notebooks.
55

66
.. image:: https://mybinder.org/badge_logo.svg
7-
:target: https://mybinder.org/v2/gh/AMICI-dev/AMICI/develop?labpath=binder%2Foverview.ipynb
7+
:target: https://mybinder.org/v2/gh/AMICI-dev/AMICI/main?labpath=binder%2Foverview.ipynb
88

99
.. toctree::
1010
:maxdepth: 1

doc/python_installation.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,9 @@ you can install AMICI with ``pip`` directly from GitHub using:
300300

301301
.. code-block:: bash
302302
303-
pip3 install -e git+https://github.com/AMICI-dev/amici.git@develop#egg=amici\&subdirectory=python/sdist
303+
pip3 install -e git+https://github.com/AMICI-dev/amici.git@main#egg=amici\&subdirectory=python/sdist
304304
305-
Replace ``develop`` by the branch or commit you want to install.
305+
Replace ``main`` by the branch or commit you want to install.
306306

307307
Note that this will only work on Windows if you have enabled developer mode,
308308
because symlinks are not supported by default

0 commit comments

Comments
 (0)