Skip to content

Commit 548f754

Browse files
committed
review comments
1 parent f8b7b21 commit 548f754

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

pytest.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ filterwarnings =
1313
ignore:Conservation laws for non-constant species in models with RateRules are currently not supported and will be turned off.:UserWarning
1414
ignore:Conservation laws for non-constant species in models with Species-AssignmentRules are currently not supported and will be turned off.:UserWarning
1515
ignore:Conservation laws for non-constant species in combination with parameterized stoichiometric coefficients are not currently supported and will be turned off.:UserWarning
16-
ignore:PEtab v2.0.0 mapping tables are only partially supported:UserWarning
1716
ignore:Support for PEtab2.0.*experimental:UserWarning
1817
ignore:The JAX module is experimental and the API may change in the future.:ImportWarning
1918
# hundreds of SBML <=5.17 warnings

python/sdist/amici/sbml_import.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def _process_document(self) -> None:
215215
log_execution_time("validating SBML", logger)(
216216
self.sbml_doc.validateSBML
217217
)()
218-
# _check_lib_sbml_errors(self.sbml_doc, self.show_sbml_warnings)
218+
_check_lib_sbml_errors(self.sbml_doc, self.show_sbml_warnings)
219219

220220
# Flatten "comp" model? Do that before any other converters are run
221221
if any(
@@ -262,7 +262,7 @@ def _process_document(self) -> None:
262262
# If any of the above calls produces an error, this will be added to
263263
# the SBMLError log in the sbml document. Thus, it is sufficient to
264264
# check the error log just once after all conversion/validation calls.
265-
# _check_lib_sbml_errors(self.sbml_doc, self.show_sbml_warnings)
265+
_check_lib_sbml_errors(self.sbml_doc, self.show_sbml_warnings)
266266

267267
# need to reload the converted model
268268
self.sbml = self.sbml_doc.getModel()

0 commit comments

Comments
 (0)