Skip to content

Commit 89fbaaf

Browse files
authored
Fix AttributeError in petab_import_pysb with petab==0.2.0 (#2079)
* Fix AttributeError in petab_import_pysb with petab==0.2.0 Closes #2078 * petab>=0.2.0
1 parent f643c0d commit 89fbaaf

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

python/sdist/amici/petab_import_pysb.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
import os
1010
from itertools import chain
1111
from pathlib import Path
12-
from typing import Dict, Iterable, Optional, Tuple, Union
12+
from typing import Dict, Iterable, Optional, Union
1313

14-
import libsbml
1514
import petab
1615
import pysb
1716
import sympy as sp
1817
from petab.C import (CONDITION_FILES, CONDITION_NAME, FORMAT_VERSION,
1918
MEASUREMENT_FILES, NOISE_FORMULA, OBSERVABLE_FILES,
2019
OBSERVABLE_FORMULA, PARAMETER_FILE, SBML_FILES,
2120
VISUALIZATION_FILES)
21+
from petab.models.sbml_model import SbmlModel
2222

2323
from .logging import get_logger, log_execution_time, set_log_level
2424

@@ -56,7 +56,7 @@ def __init__(self, pysb_model: 'pysb.Model' = None, *args, **kwargs):
5656
self._add_observation_model()
5757

5858
if self.pysb_model is not None:
59-
self.sbml_document, self.sbml_model = \
59+
self.model = \
6060
create_dummy_sbml(
6161
self.pysb_model,
6262
observable_ids=self.observable_df.index.values
@@ -252,17 +252,16 @@ def from_yaml(yaml_config: Union[Dict, Path, str],
252252
def create_dummy_sbml(
253253
pysb_model: 'pysb.Model',
254254
observable_ids: Optional[Iterable[str]] = None
255-
) -> Tuple['libsbml.Model', 'libsbml.SBMLDocument']:
255+
) -> SbmlModel:
256256
"""Create SBML dummy model for to use PySB models with PEtab.
257257
258258
Model must at least contain PEtab problem parameter and noise parameters
259259
for observables.
260260
261261
:param pysb_model: PySB model
262262
:param observable_ids: Observable IDs
263-
:return: A dummy SBML model and document.
263+
:return: A dummy petab SBML model.
264264
"""
265-
266265
import libsbml
267266

268267
document = libsbml.SBMLDocument(3, 1)
@@ -305,7 +304,7 @@ def create_dummy_sbml(
305304
s.setCompartment('dummy_compartment')
306305
s.setConstant(False)
307306

308-
return document, dummy_sbml_model
307+
return SbmlModel(sbml_model=dummy_sbml_model, sbml_document=document)
309308

310309

311310
@log_execution_time('Importing PEtab model', logger)

python/sdist/setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ include_package_data = True
4444
zip_safe = False
4545

4646
[options.extras_require]
47-
petab = petab>=0.1.27
47+
petab = petab>=0.2.0
4848
pysb = pysb>=1.13.1
4949
test =
5050
pytest

0 commit comments

Comments
 (0)