Skip to content

Commit f0bc5d1

Browse files
committed
Rename py
1 parent 65e327d commit f0bc5d1

File tree

14 files changed

+66
-64
lines changed

14 files changed

+66
-64
lines changed

doc/examples/getting_started_extended/GettingStartedExtended.ipynb

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@
415415
"print(\n",
416416
" \"Simulation was run using model default parameters as specified in the SBML model:\"\n",
417417
")\n",
418-
"print(dict(zip(model.get_free_parameter_ids(), model.get_parameters())))"
418+
"print(dict(zip(model.get_free_parameter_ids(), model.get_free_parameters())))"
419419
]
420420
},
421421
{
@@ -1111,11 +1111,11 @@
11111111
"source": [
11121112
"# Set model options\n",
11131113
"model = model_module.get_model()\n",
1114-
"p_orig = np.array(model.get_parameters())\n",
1114+
"p_orig = np.array(model.get_free_parameters())\n",
11151115
"p_orig[\n",
11161116
" list(model.get_free_parameter_ids()).index(\"observable_x1withsigma_sigma\")\n",
11171117
"] = 0.1 # Change default parameter\n",
1118-
"model.set_parameters(p_orig)\n",
1118+
"model.set_free_parameters(p_orig)\n",
11191119
"model.set_parameter_scale(amici.ParameterScaling.none)\n",
11201120
"model.set_timepoints(np.linspace(0, 10, 21))\n",
11211121
"\n",
@@ -1172,12 +1172,12 @@
11721172
" p[plist] = x0\n",
11731173
" verbose and print(f\"f: p={p}\")\n",
11741174
"\n",
1175-
" old_parameters = model.get_parameters()\n",
1175+
" old_parameters = model.get_free_parameters()\n",
11761176
" solver.set_sensitivity_order(amici.SensitivityOrder.none)\n",
1177-
" model.set_parameters(p)\n",
1177+
" model.set_free_parameters(p)\n",
11781178
" rdata = amici.run_simulation(model, solver, edata)\n",
11791179
"\n",
1180-
" model.set_parameters(old_parameters)\n",
1180+
" model.set_free_parameters(old_parameters)\n",
11811181
"\n",
11821182
" res = np.sum(rdata[symbol])\n",
11831183
" verbose and print(res)\n",
@@ -1194,13 +1194,13 @@
11941194
" model.require_sensitivities_for_all_parameters()\n",
11951195
" verbose and print(f\"g: p={p}\")\n",
11961196
"\n",
1197-
" old_parameters = model.get_parameters()\n",
1197+
" old_parameters = model.get_free_parameters()\n",
11981198
" solver.set_sensitivity_method(amici.SensitivityMethod.forward)\n",
11991199
" solver.set_sensitivity_order(amici.SensitivityOrder.first)\n",
1200-
" model.set_parameters(p)\n",
1200+
" model.set_free_parameters(p)\n",
12011201
" rdata = amici.run_simulation(model, solver, edata)\n",
12021202
"\n",
1203-
" model.set_parameters(old_parameters)\n",
1203+
" model.set_free_parameters(old_parameters)\n",
12041204
"\n",
12051205
" res = rdata[f\"s{symbol}\"]\n",
12061206
" if not isinstance(res, float):\n",
@@ -1255,7 +1255,7 @@
12551255
"outputs": [],
12561256
"source": [
12571257
"eps = 1e-4\n",
1258-
"op = model.get_parameters()\n",
1258+
"op = model.get_free_parameters()\n",
12591259
"\n",
12601260
"\n",
12611261
"solver.set_sensitivity_method(\n",
@@ -1271,23 +1271,23 @@
12711271
"\n",
12721272
"def fd(x0, ip, eps, symbol=\"llh\"):\n",
12731273
" p = list(x0[:])\n",
1274-
" old_parameters = model.get_parameters()\n",
1274+
" old_parameters = model.get_free_parameters()\n",
12751275
" solver.set_sensitivity_order(amici.SensitivityOrder.none)\n",
12761276
" p[ip] += eps\n",
1277-
" model.set_parameters(p)\n",
1277+
" model.set_free_parameters(p)\n",
12781278
" rdata_f = amici.run_simulation(model, solver, edata)\n",
12791279
" p[ip] -= 2 * eps\n",
1280-
" model.set_parameters(p)\n",
1280+
" model.set_free_parameters(p)\n",
12811281
" rdata_b = amici.run_simulation(model, solver, edata)\n",
12821282
"\n",
1283-
" model.set_parameters(old_parameters)\n",
1283+
" model.set_free_parameters(old_parameters)\n",
12841284
" return (rdata_f[symbol] - rdata_b[symbol]) / (2 * eps)\n",
12851285
"\n",
12861286
"\n",
12871287
"def plot_sensitivities(symbol, eps):\n",
12881288
" fig, axes = plt.subplots(4, 2, figsize=(15, 10))\n",
12891289
" for ip in range(4):\n",
1290-
" fd_approx = fd(model.get_parameters(), ip, eps, symbol=symbol)\n",
1290+
" fd_approx = fd(model.get_free_parameters(), ip, eps, symbol=symbol)\n",
12911291
"\n",
12921292
" axes[ip, 0].plot(\n",
12931293
" edata.get_timepoints(), rdata[f\"s{symbol}\"][:, ip, :], \"r-\"\n",

python/sdist/amici/debugging/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def get_model_for_preeq(model: amici.Model, edata: amici.ExpData):
3636
if edata.pscale:
3737
model.set_parameter_scale(edata.pscale)
3838
if edata.free_parameters:
39-
model.set_parameters(edata.free_parameters)
39+
model.set_free_parameters(edata.free_parameters)
4040
if edata.plist:
4141
model.set_parameter_list(edata.plist)
4242
model.set_initial_state(edata.x0)

python/sdist/amici/gradient_check.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def check_finite_difference(
7171

7272
# store original settings and apply new ones
7373
og_sensitivity_order = solver.get_sensitivity_order()
74-
og_parameters = model.get_parameters()
74+
og_parameters = model.get_free_parameters()
7575
og_plist = model.get_parameter_list()
7676
if edata:
7777
og_eplist = edata.plist
@@ -88,7 +88,7 @@ def check_finite_difference(
8888
model.set_parameter_list(plist)
8989

9090
model.set_parameter_scale(pscale)
91-
model.set_parameters(p)
91+
model.set_free_parameters(p)
9292

9393
# simulation with gradient
9494
if int(og_sensitivity_order) < int(SensitivityOrder.first):
@@ -110,13 +110,13 @@ def check_finite_difference(
110110
pb[ip] /= 1 + epsilon / 2
111111

112112
# forward:
113-
model.set_parameters(pf)
113+
model.set_free_parameters(pf)
114114
rdataf = run_simulation(model, solver, edata)
115115
if rdataf["status"] != AMICI_SUCCESS:
116116
raise AssertionError(f"Simulation failed (status {rdataf['status']}")
117117

118118
# backward:
119-
model.set_parameters(pb)
119+
model.set_free_parameters(pb)
120120
rdatab = run_simulation(model, solver, edata)
121121
if rdatab["status"] != AMICI_SUCCESS:
122122
raise AssertionError(f"Simulation failed (status {rdatab['status']}")
@@ -146,7 +146,7 @@ def check_finite_difference(
146146
)
147147

148148
solver.set_sensitivity_order(og_sensitivity_order)
149-
model.set_parameters(og_parameters)
149+
model.set_free_parameters(og_parameters)
150150
model.set_parameter_list(og_plist)
151151
if edata:
152152
edata.plist = og_eplist
@@ -182,7 +182,7 @@ def check_derivatives(
182182
if edata and edata.free_parameters:
183183
p = np.array(edata.free_parameters)
184184
else:
185-
p = np.array(model.get_parameters())
185+
p = np.array(model.get_free_parameters())
186186

187187
og_sens_order = solver.get_sensitivity_order()
188188

python/sdist/amici/pandas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ def _fill_conditions_dict(
421421
if len(edata.free_parameters):
422422
datadict[par] = edata.free_parameters[i_par]
423423
else:
424-
datadict[par] = model.get_parameters()[i_par]
424+
datadict[par] = model.get_free_parameters()[i_par]
425425

426426
if len(edata.pscale):
427427
datadict[par + "_scale"] = edata.pscale[i_par]

python/sdist/amici/petab/petab_importer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ def __init__(
681681
# create a new model instance from the model module from which
682682
# we can get the default parameters
683683
model0 = model.module.get_model()
684-
self._original_p = np.array(model0.get_parameters())
684+
self._original_p = np.array(model0.get_free_parameters())
685685
self._original_k = np.array(model0.get_fixed_parameters())
686686

687687
def create_edatas(self) -> list[amici.ExpData]:

python/sdist/amici/swig_wrappers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def _ids_and_names_to_rdata(
266266
"state",
267267
"observable",
268268
"expression",
269-
"parameter",
269+
"free_parameter",
270270
"fixed_parameter",
271271
):
272272
for name_or_id in ("ids", "names"):

python/tests/test_edata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_edata_sensi_unscaling(model_units_module): # noqa: F811
2828
model = model_units_module.get_model()
2929
model.set_timepoints(np.linspace(0, 1, 3))
3030
model.set_parameter_scale(parameter_scales_log10)
31-
model.set_parameters(parameters0)
31+
model.set_free_parameters(parameters0)
3232

3333
solver = model.create_solver()
3434
solver.set_sensitivity_order(amici.SensitivityOrder.first)

python/tests/test_jax.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ def _test_model(amici_module, jax_module, ts, p, k):
129129

130130
jax_model = jax_module.Model()
131131

132-
amici_model.set_parameters(np.asarray(p, dtype=np.float64))
132+
amici_model.set_free_parameters(np.asarray(p, dtype=np.float64))
133133
amici_model.set_fixed_parameters(np.asarray(k, dtype=np.float64))
134134
edata = amici.ExpData(sol_amici_ref, 1.0, 1.0)
135-
edata.free_parameters = amici_model.get_parameters()
135+
edata.free_parameters = amici_model.get_free_parameters()
136136
edata.fixed_parameters = amici_model.get_fixed_parameters()
137137
edata.pscale = amici_model.get_parameter_scale()
138138
amici_solver = amici_model.create_solver()

python/tests/test_preequilibration.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,11 @@ def test_parameter_in_expdata(preeq_fixture):
279279
model.set_parameter_list([i for i in reversed(model.get_parameter_list())])
280280

281281
# set ExpData parameters
282-
edata.free_parameters = model.get_parameters()
282+
edata.free_parameters = model.get_free_parameters()
283283
# perturb model parameters
284-
model.set_parameters(tuple(p * 2 for p in model.get_parameters()))
284+
model.set_free_parameters(
285+
tuple(p * 2 for p in model.get_free_parameters())
286+
)
285287

286288
# set ExpData pscale
287289
edata.pscale = model.get_parameter_scale()

python/tests/test_pysb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ def test_compare_to_pysb_simulation(example):
239239
ParameterScaling.log10
240240
if p > 0
241241
else ParameterScaling.none
242-
for p in model_pysb.get_parameters()
242+
for p in model_pysb.get_free_parameters()
243243
]
244244
)
245245
)

0 commit comments

Comments
 (0)