Revert to naming HelmReleases by UUID (#601)

Author: AlexGodbehere

acs-cluster-manager/lib/actions.js

@@ -201,10 +201,14 @@ export class Update extends Action {
         const cluster = cluster_template({ uuid, name });
         const values = jmp.merge(cluster.values, spec.values ?? {});
         /* Build the cluster HelmRelease manifest */
+        /* It would be better to use a more sensible name here. But this
+         * breaks back-compat; flux is unable to handle a situation
+         * where one HelmRelease is replaced by another with a different
+         * name but they deploy the same resources. */
         const helm = template.helm({
             ...cluster,
             uuid, values,
-            name: k8sname("edge-cluster", name),
+            name: k8sname("edge-cluster", uuid),
             prefix: "edge-cluster",
             source: "helm-charts"
         }).template;

acs-edge-sync/lib/deployments.js

@@ -217,7 +217,12 @@ export class Deployments {
                     name:       spec.name,
                     hostname:   spec.hostname,
                 });
-                const hr_name = k8sname(chart.prefix ?? chart.chart, spec.name);
+                /* It would be better to use a more sensible name here.
+                 * But this breaks back-compat; flux is unable to handle
+                 * a situation where one HelmRelease is replaced by
+                 * another with a different name but they deploy the
+                 * same resources. */
+                const hr_name = k8sname(chart.prefix ?? chart.chart, uuid);
                 const gr_name = k8sname("helm", chart.source ?? "charts");
 
                 const hr = templates.get(res.HelmRelease)({