GCC 10.3: Wformat-overflow

Spotted buffer overflows in `sprintf` with GCC 10.3

Author: ax3l

Dataset.cpp

@@ -431,12 +431,14 @@ void Dataset::DatasetRender(const Box &alignedRegion, AmrPicture *apptr,
   XmStringFree(sNewLevel);
 
   sprintf(minInfoV, fstring, rMin);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 156 [-Wformat-overflow=]
   sprintf(minInfo, "Min:%s", minInfoV);
   XmString sNewMin = XmStringCreateSimple(minInfo);
   XtVaSetValues(wMinValue, XmNlabelString, sNewMin, NULL);
   XmStringFree(sNewMin);
 
   sprintf(maxInfoV, fstring, rMax);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 156 [-Wformat-overflow=]
   sprintf(maxInfo, "Max:%s", maxInfoV);
   XmString sNewMax = XmStringCreateSimple(maxInfo);
   XtVaSetValues(wMaxValue, XmNlabelString, sNewMax, NULL);

PltApp.cpp

@@ -2832,6 +2832,7 @@ void PltApp::DoSetRangeButton(Widget, XtPointer, XtPointer) {
 			 rtMin, rtMax);
   sprintf(fMin, format, rtMin);
   sprintf(fMax, format, rtMax);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 155 [-Wformat-overflow=]
   sprintf(range, "Min: %s  Max: %s", fMin, fMax);
   strcpy(saveRangeString, range);
 
@@ -2964,9 +2965,11 @@ void PltApp::DoSetRangeButton(Widget, XtPointer, XtPointer) {
 			 pltAppState->CurrentDerivedNumber(), rtMin, rtMax);
   sprintf(fMin, format, rtMin);
   sprintf(fMax, format, rtMax);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 155 [-Wformat-overflow=]
   sprintf(range, "Min: %s", fMin);
   XtVaCreateManagedWidget(range, xmLabelGadgetClass, wRangeRC, NULL);
   //XtVaSetValues(wid, XmNleftOffset, 20, NULL);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 155 [-Wformat-overflow=]
   sprintf(range, "Max: %s", fMax);
   XtVaCreateManagedWidget(range, xmLabelGadgetClass, wRangeRC, NULL);
 
@@ -2975,8 +2978,10 @@ void PltApp::DoSetRangeButton(Widget, XtPointer, XtPointer) {
 			 rtMin, rtMax);
   sprintf(fMin, format, rtMin);
   sprintf(fMax, format, rtMax);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 155 [-Wformat-overflow=]
   sprintf(range, "Min: %s", fMin);
   XtVaCreateManagedWidget(range, xmLabelGadgetClass, wRangeRC, NULL);
+  // warning: '%s' directive writing up to 159 bytes into a region of size 155 [-Wformat-overflow=]
   sprintf(range, "Max: %s", fMax);
   XtVaCreateManagedWidget(range, xmLabelGadgetClass, wRangeRC, NULL);