Skip to content

Consistency with amrex/Tests #155

@philip-blakely

Description

@philip-blakely

Would it be possible to have more consistency (or less duplication) between amrex/Tests and amrex-tutorials/ExampleCodes? This might help reduce some confusion.

For example, amrex/Tests/EB_CNS does not have an equivalent in amrex-tutorials/ExampleCodes
In particular, amrex/Tests/EB_CNS can be compiled in 2D; the amrex-tutorials/ExampleCodes/EB/CNS code cannot.

For context: I asked a student to work on a 2D EB-CNS test-case, and mistakenly pointed them towards the amrex-tutorials/ExampleCodes/EB/CNS one which gave them compilation errors for 2D. I should of course have pointed them to amrex/Tests/EB_CNS instead. More consistency would have reduced the chance of me making the mistake in the first place.

There are also (very minor) differences between, for example:

  • amrex-tutorials/ExampleCodes/EB/CNS and amrex/Tests/EB/CNS
  • amrex-tutorials/ExampleCodes/LinearSolvers/ABecLaplacian_C and amrex/Tests/LinearSolvers/ABecLaplacian_C/

(and possibly others as well).

In most cases, I'm not sure whether amrex/Tests or amrex-tutorials/ExampleCodes should take priority, otherwise I would start putting together a PR myself to work towards this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions