Skip to content

Commit 0a208bb

Browse files
WeiqunZhangWeiqunZhang
authored
Clang-Tidy in CI: Keep Going after Errors (#3667)
Add `-k` to the make command running clang-tidy. With that, the jobs will keep going and show all the clang-tidy check errors instead of stopping on the first error.
1 parent d988c98 commit 0a208bb

File tree

7 files changed

+23
-23
lines changed

7 files changed

+23
-23
lines changed

‎.github/workflows/bittree.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
mpiexec -n 2 ./main2d.gnu.TEST.MPI.ex inputs_bittree amr.plot_int=1000
5353
5454
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
55-
make -j2 -f clang-tidy-ccache-misses.mak \
55+
make -j2 -k -f clang-tidy-ccache-misses.mak \
5656
CLANG_TIDY=clang-tidy-15 \
5757
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
5858
@@ -104,7 +104,7 @@ jobs:
104104
mpiexec -n 2 ./main3d.gnu.TEST.MPI.ex inputs_bittree max_step=10
105105
106106
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
107-
make -j2 -f clang-tidy-ccache-misses.mak \
107+
make -j2 -k -f clang-tidy-ccache-misses.mak \
108108
CLANG_TIDY=clang-tidy-15 \
109109
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
110110

‎.github/workflows/clang.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
make test_install
6060
6161
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
62-
make -j2 -f clang-tidy-ccache-misses.mak \
62+
make -j2 -k -f clang-tidy-ccache-misses.mak \
6363
CLANG_TIDY=clang-tidy-12 \
6464
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
6565
@@ -117,7 +117,7 @@ jobs:
117117
make -j 2
118118
119119
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
120-
make -j2 -f clang-tidy-ccache-misses.mak \
120+
make -j2 -k -f clang-tidy-ccache-misses.mak \
121121
CLANG_TIDY=clang-tidy-14 \
122122
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
123123
@@ -159,7 +159,7 @@ jobs:
159159
make install
160160
161161
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
162-
make -j2 -f clang-tidy-ccache-misses.mak \
162+
make -j2 -k -f clang-tidy-ccache-misses.mak \
163163
CLANG_TIDY=clang-tidy-14 \
164164
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
165165

‎.github/workflows/gcc.yml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
make test_install
5656
5757
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
58-
make -j2 -f clang-tidy-ccache-misses.mak \
58+
make -j2 -k -f clang-tidy-ccache-misses.mak \
5959
CLANG_TIDY=clang-tidy-12 \
6060
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
6161
@@ -107,7 +107,7 @@ jobs:
107107
cmake --build build -j 2
108108
109109
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
110-
make -j2 -f clang-tidy-ccache-misses.mak \
110+
make -j2 -k -f clang-tidy-ccache-misses.mak \
111111
CLANG_TIDY=clang-tidy-12 \
112112
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
113113
@@ -155,7 +155,7 @@ jobs:
155155
cmake --build build -j 2
156156
157157
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
158-
make -j2 -f clang-tidy-ccache-misses.mak \
158+
make -j2 -k -f clang-tidy-ccache-misses.mak \
159159
CLANG_TIDY=clang-tidy-12 \
160160
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
161161
@@ -204,7 +204,7 @@ jobs:
204204
cmake --build build -j 2
205205
206206
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
207-
make -j2 -f clang-tidy-ccache-misses.mak \
207+
make -j2 -k -f clang-tidy-ccache-misses.mak \
208208
CLANG_TIDY=clang-tidy-12 \
209209
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
210210
@@ -263,7 +263,7 @@ jobs:
263263
264264
# Let's not use clang-tidy for this test because it wants to use C++20.
265265
# ${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
266-
# make -j2 -f clang-tidy-ccache-misses.mak \
266+
# make -j2 -k -f clang-tidy-ccache-misses.mak \
267267
# CLANG_TIDY=clang-tidy-12 \
268268
# CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
269269
@@ -320,7 +320,7 @@ jobs:
320320
make -j 2
321321
322322
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
323-
make -j2 -f clang-tidy-ccache-misses.mak \
323+
make -j2 -k -f clang-tidy-ccache-misses.mak \
324324
CLANG_TIDY=clang-tidy-12 \
325325
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
326326
@@ -384,7 +384,7 @@ jobs:
384384
make -j 2
385385
386386
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
387-
make -j2 -f clang-tidy-ccache-misses.mak \
387+
make -j2 -k -f clang-tidy-ccache-misses.mak \
388388
CLANG_TIDY=clang-tidy-14 \
389389
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
390390
@@ -426,7 +426,7 @@ jobs:
426426
make install
427427
428428
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
429-
make -j2 -f clang-tidy-ccache-misses.mak \
429+
make -j2 -k -f clang-tidy-ccache-misses.mak \
430430
CLANG_TIDY=clang-tidy-12 \
431431
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
432432
@@ -466,7 +466,7 @@ jobs:
466466
make install
467467
468468
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
469-
make -j2 -f clang-tidy-ccache-misses.mak \
469+
make -j2 -k -f clang-tidy-ccache-misses.mak \
470470
CLANG_TIDY=clang-tidy-15 \
471471
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
472472
@@ -506,7 +506,7 @@ jobs:
506506
make install
507507
508508
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
509-
make -j2 -f clang-tidy-ccache-misses.mak \
509+
make -j2 -k -f clang-tidy-ccache-misses.mak \
510510
CLANG_TIDY=clang-tidy-12 \
511511
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
512512
@@ -546,7 +546,7 @@ jobs:
546546
make install
547547
548548
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
549-
make -j2 -f clang-tidy-ccache-misses.mak \
549+
make -j2 -k -f clang-tidy-ccache-misses.mak \
550550
CLANG_TIDY=clang-tidy-12 \
551551
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
552552
@@ -585,7 +585,7 @@ jobs:
585585
CCACHE=ccache
586586
587587
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
588-
make -j2 -f clang-tidy-ccache-misses.mak \
588+
make -j2 -k -f clang-tidy-ccache-misses.mak \
589589
CLANG_TIDY=clang-tidy-12 \
590590
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
591591
@@ -630,7 +630,7 @@ jobs:
630630
make -j 2
631631
632632
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
633-
make -j2 -f clang-tidy-ccache-misses.mak \
633+
make -j2 -k -f clang-tidy-ccache-misses.mak \
634634
CLANG_TIDY=clang-tidy-12 \
635635
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
636636

‎.github/workflows/hypre.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ jobs:
100100
mpiexec -n 2 ./main3d.gnu.MPI.ex inputs.hypre
101101
102102
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
103-
make -j2 -f clang-tidy-ccache-misses.mak \
103+
make -j2 -k -f clang-tidy-ccache-misses.mak \
104104
CLANG_TIDY=clang-tidy-14 \
105105
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
106106
@@ -148,7 +148,7 @@ jobs:
148148
mpiexec -n 2 ./main2d.gnu.MPI.ex inputs.2d
149149
150150
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
151-
make -j2 -f clang-tidy-ccache-misses.mak \
151+
make -j2 -k -f clang-tidy-ccache-misses.mak \
152152
CLANG_TIDY=clang-tidy-14 \
153153
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
154154

‎.github/workflows/petsc.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
mpiexec -n 2 ./main2d.gnu.TEST.MPI.ex inputs.rt.2d.petsc
5151
5252
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
53-
make -j2 -f clang-tidy-ccache-misses.mak \
53+
make -j2 -k -f clang-tidy-ccache-misses.mak \
5454
CLANG_TIDY=clang-tidy-14 \
5555
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
5656

‎.github/workflows/smoke.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
make test_install
4848
4949
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
50-
make -j2 -f clang-tidy-ccache-misses.mak \
50+
make -j2 -k -f clang-tidy-ccache-misses.mak \
5151
CLANG_TIDY=clang-tidy-15 \
5252
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
5353

‎.github/workflows/sundials.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
cmake --build build -j 2
6161
6262
${{github.workspace}}/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt
63-
make -j2 -f clang-tidy-ccache-misses.mak \
63+
make -j2 -k -f clang-tidy-ccache-misses.mak \
6464
CLANG_TIDY=clang-tidy-14 \
6565
CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
6666

0 commit comments

Comments
 (0)