ParmParse: Remove two Aborts (#4576)

ParmParse now supports names containing special characters such as `/`,
`(`, `)`, and `,` except for white space and `=` (e.g.,
`dAx_x/dx(x,y,t,zeval) = 12`). In fact, even before this PR, such names
were already supported as long as they are not the first entry, due to
the way input parsing was implemented. With this PR, these names are now
allowed as the first entry as well.

Author: WeiqunZhang

Src/Base/AMReX_ParmParse.cpp

@@ -616,10 +616,6 @@ bldTable (const char*& str, ParmParse::Table& tab)
         }
         case pEQ_sign:
         {
-            if ( cur_name.empty() )
-            {
-                amrex::Abort("ParmParse::bldTable() EQ with no current defn");
-            }
             if ( !cur_list.empty() )
             {
                 //
@@ -658,12 +654,6 @@ bldTable (const char*& str, ParmParse::Table& tab)
         }
         case pValue:
         {
-            if ( cur_name.empty() )
-            {
-                std::string msg("ParmParse::bldTable(): value with no defn: ");
-                msg += tokname;
-                amrex::Abort(msg.c_str());
-            }
             cur_list.push_back(std::move(tokname));
             cur_linefeeds.push_back(num_linefeeds);
             break;

Tests/ParmParse/inputs

@@ -1,3 +1,4 @@
+dAx_x/dx(x,y,t,zeval) = 12
 
 amrex.signal_handling = 0
 amrex.throw_exception = 1

Tests/ParmParse/main.cpp

@@ -22,6 +22,12 @@ int main(int argc, char* argv[])
         pp.add("c", 299792458.);
         pp.add("pi", 3.14159265358979323846);
     }
+    {
+        ParmParse pp;
+        int val;
+        pp.query("dAx_x/dx(x,y,t,zeval)", val);
+        AMREX_ALWAYS_ASSERT(val == 12);
+    }
     {
         ParmParse pp;