Minor Updates (#4723)

* Update documentation on Parser.
* Remove obsolete comment.
* Make IParser consistent with Parser.

Author: WeiqunZhang

Docs/sphinx_documentation/source/Basics.rst

@@ -669,8 +669,9 @@ the parser.
    parser.registerVariables({"x","y","z"});
    auto f = parser.compile<3>();  // 3 because there are three variables.
 
-   // f can be used in both host and device code.  It takes 3 arguments in
-   // this example.  The parser object must be alive for f to be valid.
+   // ParserExecutor<3> f is thread-safe, and can be used in both host and
+   // device code. It takes 3 arguments in this example. The parser object
+   // must be alive for f to be valid.
    for (int k = 0; ...) {
      for (int j = 0; ...) {
        for (int i = 0; ...) {
@@ -685,7 +686,7 @@ Local automatic variables can be defined in the expression.  For example,
 
 ::
 
-   Parser parser("r2=x*x+y*y; r=sqrt(r2); cos(a+r2)*log(r)"
+   Parser parser("r2=x*x+y*y; r=sqrt(r2); cos(a+r2)*log(r)");
    parser.setConstant("a", ...);
    parser.registerVariables({"x","y"});
    auto f = parser.compile<2>();  // 2 because there are two variables.

Src/Base/AMReX_Utility.H

@@ -94,11 +94,7 @@ namespace amrex
     void UtilCreateCleanDirectory (const std::string &path,
                                    bool callbarrier = true);
 
-    ///
-    /**
-       Create a new directory, removing old one if it exists.
-       This will only work on unix systems, as it has a system call.
-     */
+    //! Create a new directory, removing old one if it exists.
     void UtilCreateDirectoryDestructive(const std::string &path,
                                         bool callbarrier = true);
 

Src/Base/Parser/AMReX_IParser.H

@@ -111,7 +111,7 @@ IParserExecutor<N>
 IParser::compileHost () const
 {
     if (m_data && m_data->m_iparser) {
-        AMREX_ASSERT(N == m_data->m_nvars);
+        AMREX_ALWAYS_ASSERT(N == m_data->m_nvars);
 
         if (!(m_data->m_host_executor)) {
             int stack_size;