Improvements to AMREX_ASSERT (#4581)

## Summary

Previously the `AMREX_ASSERT_WITH_MESSAGE` and
`AMREX_ALWAYS_ASSERT_WITH_MESSAGE` macros converted the messege to a
string using `# MSG` which resulted in strange formatting and the
printing of runtime values to not work.

Additionally, `ALWAYS_ASSERT` and `ASSERT` did not work in device code
even when compiling with `AMREX_USE_ASSERTION` due to the `#if
defined(NDEBUG)` in `Assert (...)`.

Now `ALWAYS_ASSERT` and `ASSERT` will work in device code with
`AMREX_USE_ASSERTION`, but not without so the behaviour doesn't change
of the few places that use `ALWAYS_ASSERT` on the GPU (meaning
`ALWAYS_ASSERT` still does not always assert).

Test of the assert:

https://github.com/AMReX-Codes/amrex/blob/5bd9494f9229b6a7a60cbc6f2560e5a831aaa3de/Src/Particle/AMReX_StructOfArrays.H#L122

Dev:
```
0::Assertion `pos != m_rdata_names->end()' failed, file "/users/sinnalex/hipace/build/_deps/fetchedamrex-src/Src/Particle/AMReX_StructOfArrays.H", line 122,
Msg: "Soa Real name='" + name + "' was not found components" !!!
SIGABRT
See Backtrace.0 file for details
```
PR:
```
0::Assertion `pos != m_rdata_names->end()' failed, file "/users/sinnalex/amrex/Src/Particle/AMReX_StructOfArrays.H", line 122, 
Msg: Soa Real name='wrong name' was not found components !!!
SIGABRT
See Backtrace.0 file for details
```

Author: AlexanderSinn

Src/Base/AMReX.H

@@ -11,6 +11,7 @@
 #include <AMReX_Extension.H>
 
 #include <cstdint>
+#include <cstring>
 #include <functional>
 #include <iostream>
 #include <memory>
@@ -188,25 +189,40 @@ namespace amrex
     * in <AMReX_BLassert.H>.
     */
 
-    void Assert_host (const char* EX, const char* file, int line, const char* msg);
+    void Assert_host (const char* EX, const char* file, int line, const char* msg,
+                      std::size_t msg_size=0);
 
     AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE
-    void Assert (const char* EX, const char* file, int line, const char* msg = nullptr) {
-#if defined(NDEBUG)
+    void Assert (const char* EX, const char* file, int line) {
+#if defined(NDEBUG) && !defined(AMREX_USE_ASSERTION)
+        AMREX_IF_ON_DEVICE((amrex::ignore_unused(EX,file,line);))
+#else
+        AMREX_IF_ON_DEVICE((
+            AMREX_DEVICE_PRINTF("Assertion `%s' failed, file \"%s\", line %d",
+                                    EX, file, line);
+            AMREX_DEVICE_ASSERT(0);
+        ))
+#endif
+        AMREX_IF_ON_HOST((Assert_host(EX,file,line,nullptr,0U);))
+    }
+
+    AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE
+    void Assert (const char* EX, const char* file, int line, const char* msg) {
+#if defined(NDEBUG) && !defined(AMREX_USE_ASSERTION)
         AMREX_IF_ON_DEVICE((amrex::ignore_unused(EX,file,line,msg);))
 #else
         AMREX_IF_ON_DEVICE((
-                if (msg) {
-                AMREX_DEVICE_PRINTF("Assertion `%s' failed, file \"%s\", line %d, Msg: %s",
-                                        EX, file, line, msg);
-                } else {
-                AMREX_DEVICE_PRINTF("Assertion `%s' failed, file \"%s\", line %d",
-                                        EX, file, line);
-                }
-                AMREX_DEVICE_ASSERT(0);
+            AMREX_DEVICE_PRINTF("Assertion `%s' failed, file \"%s\", line %d, Msg: %s",
+                                    EX, file, line, msg);
+            AMREX_DEVICE_ASSERT(0);
         ))
 #endif
-        AMREX_IF_ON_HOST((Assert_host(EX,file,line,msg);))
+        AMREX_IF_ON_HOST((Assert_host(EX,file,line,msg,std::strlen(msg));))
+    }
+
+    AMREX_FORCE_INLINE
+    void Assert (const char* EX, const char* file, int line, const std::string& msg) {
+        Assert_host(EX,file,line,msg.c_str(),msg.size());
     }
 
     /**

Src/Base/AMReX.cpp

@@ -269,25 +269,26 @@ amrex::Warning_host (const char * msg)
 }
 
 void
-amrex::Assert_host (const char* EX, const char* file, int line, const char* msg)
+amrex::Assert_host (const char* EX, const char* file, int line, const char* msg,
+                    std::size_t msg_size)
 {
 #ifdef AMREX_USE_COVERITY
     amrex_coverity_abort();
 #else
-    const int N = 512;
+    const std::size_t N = 512 + msg_size;
 
-    char buf[N];
+    std::vector<char> buf(N);
 
     if (msg) {
-        snprintf(buf,
+        snprintf(buf.data(),
                  N,
                  "Assertion `%s' failed, file \"%s\", line %d, Msg: %s",
                  EX,
                  file,
                  line,
                  msg);
     } else {
-        snprintf(buf,
+        snprintf(buf.data(),
                  N,
                  "Assertion `%s' failed, file \"%s\", line %d",
                  EX,
@@ -296,11 +297,11 @@ amrex::Assert_host (const char* EX, const char* file, int line, const char* msg)
     }
 
     if (system::error_handler) {
-        system::error_handler(buf);
+        system::error_handler(buf.data());
     } else if (system::throw_exception) {
-        throw RuntimeError(buf);
+        throw RuntimeError(buf.data());
     } else {
-       write_to_stderr_without_buffering(buf);
+       write_to_stderr_without_buffering(buf.data());
 #ifdef AMREX_USE_OMP
 #pragma omp critical (amrex_abort_omp_critical)
 #endif

Src/Base/AMReX_BLassert.H

@@ -40,13 +40,13 @@
 
 #else
 
-#define AMREX_ASSERT_WITH_MESSAGE(EX,MSG) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__ , # MSG)
+#define AMREX_ASSERT_WITH_MESSAGE(EX,MSG) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__ , MSG)
 #define AMREX_ASSERT(EX) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__)
 #define    BL_ASSERT(EX) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__)
 
 #endif
 
-#define AMREX_ALWAYS_ASSERT_WITH_MESSAGE(EX,MSG) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__ , # MSG)
+#define AMREX_ALWAYS_ASSERT_WITH_MESSAGE(EX,MSG) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__ , MSG)
 #define AMREX_ALWAYS_ASSERT(EX) (EX)?((void)0):amrex::Assert( # EX , __FILE__, __LINE__)
 
 

Src/Base/AMReX_DistributionMapping.cpp

@@ -2044,7 +2044,7 @@ DistributionMapping MakeSimilarDM (const BoxArray& ba, const BoxArray& src_ba,
                                    const DistributionMapping& src_dm, const IntVect& ng)
 {
     AMREX_ASSERT_WITH_MESSAGE(ba.ixType() == src_ba.ixType(),
-                              "input BoxArrays must have the same centering.";);
+                              "input BoxArrays must have the same centering.");
 
     Vector<int> pmap(ba.size());
     for (int i = 0; i < static_cast<int>(ba.size()); ++i) {

Src/Base/AMReX_MFIter.cpp

@@ -279,7 +279,7 @@ MFIter::Initialize ()
     {
         ++depth;
         AMREX_ALWAYS_ASSERT_WITH_MESSAGE(depth == 1 || MFIter::allow_multiple_mfiters,
-            "Nested or multiple active MFIters is not supported by default.  This can be changed by calling MFIter::allowMultipleMFIters(true)".);
+            "Nested or multiple active MFIters is not supported by default.  This can be changed by calling MFIter::allowMultipleMFIters(true)");
     }
 
 #if defined(AMREX_USE_GPU) && defined(AMREX_USE_OMP)