Skip to content

Commit d9e3089

Browse files
authored
These methods throw exceptions, so they should not be noexcept (#4558)
This fixes a defect found by Coverity Scan. I think the exception comes from the ParmParse constructor.
1 parent 49ea339 commit d9e3089

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Src/Base/AMReX_TinyProfiler.H

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ public:
5151
std::map<std::string, MemStat>& memstats) noexcept;
5252
static void memory_free (std::size_t nbytes, MemStat* stat) noexcept;
5353

54-
static void Initialize () noexcept;
54+
static void Initialize ();
5555
static void Finalize (bool bFlushing = false) noexcept;
5656

57-
static void MemoryInitialize () noexcept;
57+
static void MemoryInitialize ();
5858
static void MemoryFinalize (bool bFlushing = false) noexcept;
5959

6060
static bool RegisterArena (const std::string& memory_name,

Src/Base/AMReX_TinyProfiler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ TinyProfiler::memory_free (std::size_t nbytes, MemStat* stat) noexcept
308308

309309

310310
void
311-
TinyProfiler::Initialize () noexcept
311+
TinyProfiler::Initialize ()
312312
{
313313
{
314314
amrex::ParmParse pp("tiny_profiler");
@@ -332,7 +332,7 @@ TinyProfiler::Initialize () noexcept
332332
}
333333

334334
void
335-
TinyProfiler::MemoryInitialize () noexcept
335+
TinyProfiler::MemoryInitialize ()
336336
{
337337
{
338338
amrex::ParmParse pp("tiny_profiler");

0 commit comments

Comments
 (0)