Skip to content

Commit b46cf27

Browse files
committed
fix: syntax error raised when parsing large override files
1 parent 48e691e commit b46cf27

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/common/overrides.zig

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,15 @@ pub const OverrideMap = struct {
5252

5353
pub fn read_overrides(alloc: Allocator, cp: CommonPaths) !OverrideMap {
5454
var file_bufreader = std.io.bufferedReader(cp.overrides.reader());
55-
var file_reader = file_bufreader.reader();
56-
var buff: [100]u8 = undefined;
55+
const file_reader = file_bufreader.reader();
5756

5857
var overrides = OverrideMap{ .backing_map = json.ObjectMap.init(alloc), .allocator = alloc };
5958

6059
// HACK: Here we are ensuring that the overrides.json file isn't empty, otherwise the json parsing will return an
61-
// error. Instead if the file is empty, we create ab enott StringArrayHashMap to hold our overrides.
60+
// error. Instead if the file is empty, we create StringArrayHashMap to hold our overrides.
6261
// Typically we would prefer the pread() function but its currently broken for Windows, hence we do hacky method
6362
// by checking if there bytes can be read and then resetting the file cursor back to 0.
64-
if (try file_reader.read(&buff) != 0) {
63+
if (try cp.overrides.getEndPos() != 0) {
6564
try cp.overrides.seekTo(0);
6665
var json_reader = json.reader(alloc, file_reader);
6766
const parsed = try json.parseFromTokenSource(json.Value, alloc, &json_reader, .{});

0 commit comments

Comments
 (0)