TestOpen test cases

[aerinng]

This is for case SOCKET. In the skeleton code, I noticed there is this line SystemCallInterface(AF_INET, IPPROTO_TCP, host). PA2 also mentioned that "In KENS, you need to implement only domain AF_INET, type SOCK_STREAM, and protocol IPPROTO_TCP." Hence I want to check if we are required to pass in the domain, type and protocol to implement case SOCKET as I don't seem to see type in SystemCallInterface? Or is createFileDescriptor(pid) sufficient as I cannot seem to pass all the test cases. Thank you!

[Pusnow]

KENSv3/src/Networking/TCP/E_TCPApplication.cpp

Lines 14 to 21 in 0226d32

	int TCPApplication::socket(int domain, int type__unused, int protocol) {
	SystemCallInterface::SystemCallParameter param;
	param.params[0] = domain;
	param.params[1] = type__unused;
	param.params[2] = protocol;
	param.syscallNumber = SystemCallInterface::SystemCall::SOCKET;
	int ret = E_Syscall(param);
	return ret;

KENS ignores the type option and never uses it.

KENSv3/src/Networking/E_Host.cpp

Line 117 in 0226d32

Namespace ns = Namespace(domain, protocol);

KENS only uses domain and protocol to figure out which networking stack (TCP or UDP) to use.

I want to check if we are required to pass in the domain, type and protocol to implement case SOCKET as I don't seem to see type in SystemCallInterface? Or is createFileDescriptor(pid) sufficient as I cannot seem to pass all the test cases.

No, you don't need to do so. You can assume all socket system callback in the TCPAssignment is AF_INET , SOCK_STREAM , and IPPROTO_TCP . Also,createFileDescriptor(pid) is sufficient.

[aerinng]

I only used createFileDescriptor(pid) in my returnSystemCall but I failed the test cases. May I ask for some help?

[Pusnow]

See #56. You should implement close() also.

[aerinng]

I have implemented close() and timer and still get the same error. I would like to check if we are required to catch any errors from close() and then do returnSystemCall(syscallUUID, -1)? Or is returning returnSystemCall(syscallUUID, 0) sufficient for close()?

[Pusnow]

Your fail count is 130048. In the test case, all socket calls must succeed.

I would like to check if we are required to catch any errors from close() and then do returnSystemCall(syscallUUID, -1)?

Which error? There should be no errors.

The test case should proceed like this:

1. call socket() 1024 times. They return positive file descriptors (checked by next if statement).
2. check duplicated file descriptors. There should no duplication.
3. close all file descriptors.
4. Goto 1 and repeat 128 times. Since all file descriptors are closed. Same numbers will be returned in the first step.
5. Lastly, check the number of success (must be 1024*128), fail (must be 0), and duplication (must be 0).