Skip to content

Commit 47c0c8a

Browse files
committed
Fix analyzer warnings: use indexers and rename TestDoubles to Messages
1 parent a133efb commit 47c0c8a

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed
File renamed without changes.

SWEN3.Paperless.RabbitMq.Tests/Unit/RabbitMqConsumerFactoryTests.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,24 @@ public async Task CreateConsumerAsync_ShouldDeriveQueueNameFromType()
3737
GetQueueName(consumer).Should().Be("SimpleMessageQueue");
3838
}
3939

40+
[Fact]
41+
public async Task CreateConsumerAsync_ShouldForwardCancellationTokens()
42+
{
43+
var connectionShutdown = new ShutdownEventArgs(ShutdownInitiator.Application, 200, "closing");
44+
var channelShutdown = new ShutdownEventArgs(ShutdownInitiator.Application, 200, "channel closing");
45+
_connectionMock.Setup(c => c.CloseReason).Returns(connectionShutdown);
46+
_channelMock.Setup(c => c.CloseReason).Returns(channelShutdown);
47+
_connectionMock.Setup(c => c.CreateChannelAsync(options: null, connectionShutdown.CancellationToken))
48+
.ReturnsAsync(_channelMock.Object);
49+
_channelMock.Setup(c => c.BasicQosAsync(0, 1, false, channelShutdown.CancellationToken))
50+
.Returns(Task.CompletedTask);
51+
52+
await using var _ = await _factory.CreateConsumerAsync<Messages.SimpleMessage>();
53+
54+
_connectionMock.Verify(c => c.CreateChannelAsync(options: null, connectionShutdown.CancellationToken), Times.Once);
55+
_channelMock.Verify(c => c.BasicQosAsync(0, 1, false, channelShutdown.CancellationToken), Times.Once);
56+
}
57+
4058
private static string GetQueueName(RabbitMqConsumer<Messages.SimpleMessage> consumer) =>
4159
(string)typeof(RabbitMqConsumer<Messages.SimpleMessage>)
4260
.GetField("_queueName", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance)!

SWEN3.Paperless.RabbitMq.Tests/Unit/SseStreamTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,19 +69,19 @@ public async Task Publish_WhenClientIsSlow_ShouldDropOldestMessages()
6969

7070
// Assert: Read all available messages
7171
var receivedMessages = new List<Messages.SimpleMessage>();
72-
72+
7373
// Read until empty (try-read pattern is safer than assuming exact count due to concurrency)
7474
while (reader.TryRead(out var msg))
7575
{
7676
receivedMessages.Add(msg);
7777
}
7878

7979
// Since it's a bounded channel, reader might not be empty immediately if we were reading in parallel,
80-
// but here we are single-threaded in test.
80+
// but here we are single-threaded in test.
8181
// However, strictly speaking, TryRead returns what's currently available.
82-
82+
8383
receivedMessages.Should().HaveCount(100); // Should match capacity
84-
receivedMessages.First().Id.Should().Be(expectedFirstMessageId); // Should start from 11
85-
receivedMessages.Last().Id.Should().Be(messagesToSend); // Should end at 110
84+
receivedMessages[0].Id.Should().Be(expectedFirstMessageId); // Should start from 11
85+
receivedMessages[^1].Id.Should().Be(messagesToSend); // Should end at 110
8686
}
8787
}

0 commit comments

Comments
 (0)