-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update marketplace.json - remove deleted plugins #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the accuracy and relevance of the plugin marketplace. It removes references to plugins that are no longer available and updates the metadata, including descriptions and version numbers, for two existing plugins. This ensures that the marketplace provides up-to-date information to users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughThe marketplace.json plugin registry was updated by removing three plugin entries (smart-commit, jules-integration, testcontainers-dotnet) and updating version numbers and metadata for two existing plugins (metacognitive-guard and otelwiki). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates marketplace.json by removing references to three deleted plugins and updating the versions and descriptions for metacognitive-guard and otelwiki. The changes align with the information in the individual plugin configuration files. However, the CHANGELOG.md file has not been updated to reflect the removal of the plugins, which is a required step for non-trivial changes according to the repository's style guide.
I am having trouble creating individual review comments. Click here to see my feedback.
.claude-plugin/marketplace.json (23-40)
While the removal of these plugins from the marketplace file is correct, this is a significant change that needs to be documented in the project's changelog.
According to the repository's style guide, CHANGELOG.md must be updated for any non-trivial change. Please add an entry under the ### Removed section in CHANGELOG.md for the [Unreleased] version to list the plugins that were removed (smart-commit, jules-integration, testcontainers-dotnet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude Code Review (Opus 4.5)
Verdict: ✅ APPROVED
Summary
This PR synchronizes marketplace.json with the actual plugin filesystem state by:
- Removing references to 3 deleted plugins: smart-commit, jules-integration, testcontainers-dotnet
- Updating metacognitive-guard version from 0.1.0 to 0.2.3 with updated description
- Updating otelwiki version from 1.0.0 to 1.0.3
Verification
| Check | Status |
|---|---|
| JSON syntax valid | PASS |
| Plugin versions match plugin.json | PASS |
| Deleted plugins do not exist in filesystem | PASS |
| Remaining plugins exist in filesystem | PASS |
| No Type T violations (C#/.NET) | PASS |
| No secrets exposed | PASS |
Findings
None blocking. This is a straightforward housekeeping fix to align the marketplace manifest with reality.
Minor observation: No CHANGELOG entry, but this is acceptable for sync/maintenance fixes that correct metadata to match existing state.
Strengths
- Clean, minimal diff (3 additions, 21 deletions)
- Version numbers verified against individual plugin.json files
- Descriptions correctly updated to match plugin.json
Autonomous review by Claude Opus 4.5 (Type A repo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR cleans up the marketplace plugin registry by removing references to three deleted plugins and synchronizing version numbers with current plugin manifests.
- Removes three deleted plugins: smart-commit, jules-integration, and testcontainers-dotnet
- Updates metacognitive-guard from v0.1.0 to v0.2.3 with enhanced description
- Updates otelwiki from v1.0.0 to v1.0.3
| { | ||
| "name": "metacognitive-guard", | ||
| "description": "Detects when Claude is struggling and escalates to deep-thinking agents for better responses with fewer tokens.", | ||
| "version": "0.1.0", | ||
| "description": "Cognitive amplification stack: prevents hallucinations via epistemic hooks, competitive code review, fact-checking, and deep-thinking agents.", | ||
| "version": "0.2.3", | ||
| "source": "./plugins/metacognitive-guard" | ||
| }, | ||
| { | ||
| "name": "otelwiki", | ||
| "description": "Unified OpenTelemetry documentation with auto-sync. Auto-triggers on telemetry work, provides semantic conventions, collector config, and .NET 10 instrumentation guidance.", | ||
| "version": "1.0.0", | ||
| "version": "1.0.3", | ||
| "source": "./plugins/otelwiki" | ||
| }, |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to section 5 of the coding guidelines (.github/copilot-instructions.md), any change that affects external behavior must update CHANGELOG.md with an entry under "## [Unreleased]". This PR removes three plugins from the marketplace (smart-commit, jules-integration, testcontainers-dotnet) and updates two plugin versions (metacognitive-guard to 0.2.3, otelwiki to 1.0.3), but there is no corresponding CHANGELOG.md entry for these changes. Please add a "Changed" or "Removed" section entry documenting this marketplace update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.claude-plugin/marketplace.json (1)
10-47: Remove stale plugin references from agent configuration and orchestration scripts.Plugin directories are deleted, but configuration files still reference the removed plugins. Update
agents/workflow-orchestrator/config/agent.jsonto removesmart-commitandjules-integrationfrom the required/optional arrays (lines 13–14) and skills dependencies (lines 21–22, 47, 64). Also remove references fromagents/workflow-orchestrator/scripts/orchestrate.sh(lines 87, 102, 107).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.claude-plugin/marketplace.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Upload results
- GitHub Check: Claude Review
🔇 Additional comments (2)
.claude-plugin/marketplace.json (2)
25-26: Version and description verified—metadata is consistent.The plugin directory exists with proper structure, and both the version (0.2.3) and description in marketplace.json match the plugin metadata exactly. No changes needed.
32-32: Version 1.0.3 is consistent with the otelwiki plugin entry.The patch version bump is appropriate for the plugin updates, and the marketplace.json entry is properly configured with matching source path.
Removes references to deleted plugins (smart-commit, jules-integration, testcontainers-dotnet) and updates versions for metacognitive-guard (0.2.3) and otelwiki (1.0.3).
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.