feat(oma-pm): not allow delete current kernel in AOSC OS (#535)

* feat(oma-pm)!: not allow delete current kernel in AOSC OS

* chore(i18n): improve UI prompts for current kernel removal

---------

Co-authored-by: Mingcong Bai <[email protected]>

Author: eatradish

Cargo.lock

@@ -296,3 +296,4 @@ successfully-refresh-without-status = Successfully refreshed the package databas
 not-allow-delete-using-kernel = Not allow deletion of the Linux kernel version in use: { $ver }.
 yes-mode-conflict-ui = `--yes` mode will not be applied in UI mode.
 oma-refresh-no-metadata-to-download = No suitable package metadata available based on your repository configuration.
+delete-current-kernel-tips = { $kernel } is currently in use, removing it may render the system inoperable.

i18n/en-US/oma.ftl

@@ -289,3 +289,4 @@ update-available-2 = oma 已检测到您的系统有以下可用更新：
 not-allow-delete-using-kernel = 不允许删除正在使用的 Linux 内核版本：{ $ver }。
 yes-mode-conflict-ui = UI 模式下将不会应用 `--yes` 模式。
 oma-refresh-no-metadata-to-download = 源配置中没有适用的软件包元数据。
+delete-current-kernel-tips = { $kernel } 为正在使用的内核，移除后可能导致系统无法工作。

i18n/zh-CN/oma.ftl

@@ -36,9 +36,10 @@ memchr = "2"
 serde = { version = "1", features = ["derive"] }
 apt-auth-config = { version = "0.4.0", path = "../apt-auth-config" }
 once_cell = "1.20"
+sysinfo = { version = "0.37", optional = true }
 
 [dev-dependencies]
 flume = "0.11"
 
 [features]
-aosc = []
+aosc = ["dep:sysinfo"]

oma-pm/Cargo.toml

@@ -531,7 +531,28 @@ impl OmaApt {
         let sort = PackageSort::default().installed();
         let pkgs = self.cache.packages(&sort);
 
+        #[cfg(feature = "aosc")]
+        let image_name = OnceCell::new();
+
+        #[cfg(feature = "aosc")]
+        let current_kernel_ver = OnceCell::new();
+
         for pkg in pkgs {
+            #[cfg(feature = "aosc")]
+            if pkg.name().starts_with("linux-kernel-") {
+                let current_kernel_ver = current_kernel_ver
+                    .get_or_init(|| sysinfo::System::kernel_version().unwrap_or_default());
+
+                if crate::utils::pkg_is_current_kernel(
+                    Path::new(&self.sysroot()),
+                    &image_name,
+                    pkg.name(),
+                    current_kernel_ver,
+                ) {
+                    continue;
+                }
+            }
+
             if pkg.is_auto_removable() && !pkg.marked_delete() {
                 pkg.mark_delete(purge);
                 pkg.protect();
@@ -557,7 +578,7 @@ impl OmaApt {
         custom_download_message: Option<CustomDownloadMessage>,
         callback: impl AsyncFn(Event),
     ) -> OmaAptResult<()> {
-        let sysroot = self.config.get("Dir").unwrap_or("/".to_string());
+        let sysroot = self.sysroot();
 
         if self.dry_run {
             debug!("op: {op:?}");
@@ -577,6 +598,10 @@ impl OmaApt {
         Ok(())
     }
 
+    fn sysroot(&self) -> String {
+        self.config.get("Dir").unwrap_or_else(|| "/".to_string())
+    }
+
     pub fn fix_resolver_broken(&self) {
         self.cache.fix_broken();
     }

oma-pm/src/apt.rs

@@ -40,6 +40,7 @@ pub use search::PackageStatus;
 mod commit;
 mod dbus;
 mod download;
+pub mod utils;
 pub use commit::CommitNetworkConfig;
 pub mod sort;
 pub use oma_apt::records::RecordField;

oma-pm/src/lib.rs

@@ -0,0 +1,75 @@
+use std::{fs, io, path::Path};
+
+#[cfg(feature = "aosc")]
+pub fn pkg_is_current_kernel(
+    sysroot: &Path,
+    image_name: &once_cell::sync::OnceCell<Option<String>>,
+    pkg_name: &str,
+    current_kernel_ver: &str,
+) -> bool {
+    fn is_installed_pkg_contains_file_impl(
+        pkg_name: &str,
+        image_names: &[impl AsRef<str>],
+        sysroot: &Path,
+    ) -> bool {
+        is_installed_pkg_contains_file(pkg_name, image_names, sysroot).unwrap_or_else(|e| {
+            tracing::warn!("Failed to get package {pkg_name} file list: {e}");
+            false
+        })
+    }
+
+    let image_name = image_name.get_or_init(get_kernel_image_filename);
+    tracing::debug!("image name = {image_name:?}");
+
+    if let Some(image_name) = image_name {
+        is_installed_pkg_contains_file_impl(pkg_name, &[image_name], sysroot)
+    } else {
+        is_installed_pkg_contains_file_impl(
+            pkg_name,
+            &[
+                format!("vmlinux-{current_kernel_ver}"),
+                format!("vmlinuz-{current_kernel_ver}"),
+            ],
+            sysroot,
+        )
+    }
+}
+
+#[cfg(feature = "aosc")]
+fn get_kernel_image_filename() -> Option<String> {
+    let cmdline = fs::read_to_string("/proc/cmdline").ok()?;
+
+    for i in cmdline.split_ascii_whitespace() {
+        if let Some(image_path) = i.strip_prefix("BOOT_IMAGE=") {
+            return Some(
+                Path::new(image_path)
+                    .file_name()
+                    .map(|x| x.to_string_lossy().to_string())
+                    .unwrap_or_else(|| image_path.to_string()),
+            );
+        }
+    }
+
+    None
+}
+
+pub fn is_installed_pkg_contains_file(
+    pkg_name: &str,
+    file_names: &[impl AsRef<str>],
+    sysroot: &Path,
+) -> io::Result<bool> {
+    let p = sysroot.join(format!("var/lib/dpkg/info/{pkg_name}.list"));
+    let file = fs::read_to_string(&p)?;
+
+    for line in file.lines() {
+        if Path::new(line).file_name().is_some_and(|n| {
+            file_names
+                .iter()
+                .any(|name| name.as_ref() == n.to_string_lossy())
+        }) {
+            return Ok(true);
+        }
+    }
+
+    Ok(false)
+}

oma-pm/src/utils.rs

@@ -79,6 +79,12 @@ impl OmaProgressBar {
     }
 }
 
+impl Drop for OmaProgressBar {
+    fn drop(&mut self) {
+        self.inner.finish_and_clear();
+    }
+}
+
 impl Writeln for OmaProgressBar {
     fn writeln(&self, prefix: &str, msg: &str) -> std::io::Result<()> {
         let max_len = WRITER.get_max_len();

src/pb.rs

@@ -243,6 +243,9 @@ impl CliExecuter for Remove {
 
         let pb = create_progress_spinner(no_progress, fl!("resolving-dependencies"));
 
+        #[cfg(feature = "aosc")]
+        check_is_current_kernel_deleting(config, &sysroot, &pkgs, &pb)?;
+
         let context = apt.remove(pkgs, remove_config, no_autoremove)?;
 
         if let Some(pb) = pb {
@@ -278,6 +281,50 @@ impl CliExecuter for Remove {
     }
 }
 
+#[cfg(feature = "aosc")]
+fn check_is_current_kernel_deleting(
+    config: &Config,
+    sysroot: &std::path::Path,
+    pkgs: &[oma_pm::pkginfo::OmaPackageWithoutVersion],
+    pb: &Option<crate::pb::OmaProgressBar>,
+) -> Result<(), OutputError> {
+    use anyhow::Context;
+    use once_cell::sync::OnceCell;
+
+    if let Some(pb) = pb {
+        pb.inner.finish_and_clear();
+    }
+
+    let image_name = OnceCell::new();
+    let current_kernel_ver = OnceCell::new();
+
+    for pkg in pkgs
+        .iter()
+        .filter(|pkg| pkg.raw_pkg.name().starts_with("linux-kernel-"))
+    {
+        let current_kernel_ver =
+            current_kernel_ver.get_or_try_init(|| -> anyhow::Result<String> {
+                sysinfo::System::kernel_version().context("Failed to get kernel version")
+            })?;
+
+        if oma_pm::utils::pkg_is_current_kernel(
+            sysroot,
+            &image_name,
+            pkg.raw_pkg.name(),
+            current_kernel_ver,
+        ) && (config.protect_essentials()
+            || !ask_user_delete_current_kernel(pkg.raw_pkg.name()).unwrap_or(false))
+        {
+            return Err(OutputError {
+                description: fl!("not-allow-delete-using-kernel", ver = current_kernel_ver),
+                source: None,
+            });
+        }
+    }
+
+    Ok(())
+}
+
 /// "Yes Do as I say" steps
 pub fn ask_user_do_as_i_say(pkg: &str) -> anyhow::Result<bool> {
     let theme = ColorfulTheme::default();
@@ -313,3 +360,22 @@ pub fn ask_user_do_as_i_say(pkg: &str) -> anyhow::Result<bool> {
 
     Ok(true)
 }
+
+#[cfg(feature = "aosc")]
+fn ask_user_delete_current_kernel(pkg: &str) -> anyhow::Result<bool> {
+    let theme = ColorfulTheme::default();
+
+    warn!("{}", fl!("delete-current-kernel-tips", kernel = pkg));
+
+    let delete = Confirm::with_theme(&theme)
+        .with_prompt(fl!("essential-continue"))
+        .default(false)
+        .interact()
+        .map_err(|_| anyhow!(""))?;
+
+    if !delete {
+        return Ok(false);
+    }
+
+    Ok(true)
+}

src/subcommand/remove.rs

@@ -1,6 +1,5 @@
 use std::{
     fmt::Display,
-    fs,
     path::{Path, PathBuf},
     sync::atomic::Ordering,
 };
@@ -16,6 +15,7 @@ use oma_pm::{
     apt::{AptConfig, FilterMode, OmaApt, OmaAptArgs},
     matches::{GetArchMethod, PackagesMatcher},
     pkginfo::OmaPackageWithoutVersion,
+    utils::pkg_is_current_kernel,
 };
 use oma_utils::dpkg::dpkg_arch;
 use once_cell::sync::OnceCell;
@@ -276,47 +276,24 @@ impl CliExecuter for Topics {
 
                 // linux-kernel-VER 包在关闭 topic 的时候应该直接删除
                 if pkg_name.starts_with("linux-kernel-") {
-                    let kernel_ver = kernel_ver.get_or_try_init(|| {
+                    let current_kernel_ver = kernel_ver.get_or_try_init(|| {
                         System::kernel_version().context("Failed to get kernel version")
                     })?;
 
-                    debug!("kernel version = {kernel_ver}");
-
-                    let image_name = image_name.get_or_init(get_kernel_image_filename);
-                    debug!("image name = {image_name:?}");
-
-                    let mut is_current_kernel = false;
-
-                    if let Some(image_name) = image_name {
-                        is_current_kernel =
-                            is_installed_pkg_contains_file(pkg_name, image_name, &sysroot)
-                                .unwrap_or_else(|e| {
-                                    warn!("{e}");
-                                    false
-                                });
-                    } else {
-                        for i in ["vmlinuz", "vmlinux"] {
-                            if is_installed_pkg_contains_file(
-                                pkg_name,
-                                &format!("{i}-{kernel_ver}"),
-                                &sysroot,
-                            )
-                            .unwrap_or_else(|e| {
-                                warn!("{e}");
-                                false
-                            }) {
-                                is_current_kernel = true;
-                                break;
-                            }
-                        }
-                    }
+                    debug!("kernel version = {current_kernel_ver}");
+
+                    let is_current_kernel =
+                        pkg_is_current_kernel(&sysroot, &image_name, pkg_name, current_kernel_ver);
 
                     debug!("Deleting kernel package name = {pkg_name}");
 
                     // 如果现在删除的版本是正在使用的内核版本，将拒绝操作
                     if is_current_kernel {
                         return Err(OutputError {
-                            description: fl!("not-allow-delete-using-kernel", ver = kernel_ver),
+                            description: fl!(
+                                "not-allow-delete-using-kernel",
+                                ver = current_kernel_ver
+                            ),
                             source: None,
                         });
                     }
@@ -418,44 +395,6 @@ impl CliExecuter for Topics {
     }
 }
 
-fn is_installed_pkg_contains_file(
-    pkg_name: &str,
-    file_name: &str,
-    sysroot: &Path,
-) -> anyhow::Result<bool> {
-    let p = sysroot.join(format!("var/lib/dpkg/info/{pkg_name}.list"));
-    let file = fs::read_to_string(&p)
-        .with_context(|| format!("Failed to read dpkg list file: {}", p.display()))?;
-
-    for line in file.lines() {
-        if Path::new(line)
-            .file_name()
-            .is_some_and(|n| n.to_string_lossy() == file_name)
-        {
-            return Ok(true);
-        }
-    }
-
-    Ok(false)
-}
-
-fn get_kernel_image_filename() -> Option<String> {
-    let cmdline = fs::read_to_string("/proc/cmdline").ok()?;
-
-    for i in cmdline.split_ascii_whitespace() {
-        if let Some(image_path) = i.strip_prefix("BOOT_IMAGE=") {
-            return Some(
-                Path::new(image_path)
-                    .file_name()
-                    .map(|x| x.to_string_lossy().to_string())
-                    .unwrap_or_else(|| image_path.to_string()),
-            );
-        }
-    }
-
-    None
-}
-
 fn refresh<'a>(
     network_threads: usize,
     no_progress: bool,