Skip to content

Commit cb1215b

Browse files
committed
loader/mips64: fix warnings and style
1 parent 1c99dd6 commit cb1215b

File tree

1 file changed

+44
-38
lines changed

1 file changed

+44
-38
lines changed

grub-core/loader/mips64/linux.c

Lines changed: 44 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@ grub_linux_boot (void)
124124

125125
/* Boot the kernel. */
126126
state.gpr[1] = entry_addr;
127-
grub_dprintf("loongson", "entry_addr is %p\n", state.gpr[1]);
127+
grub_dprintf("loongson", "entry_addr is %p\n", (void *) state.gpr[1]);
128128
state.gpr[4] = linux_argc;
129-
grub_dprintf("loongson", "linux_argc is %d\n", state.gpr[4]);
129+
grub_dprintf("loongson", "linux_argc is %d\n", (int) state.gpr[4]);
130130
state.gpr[5] = (grub_addr_t) linux_args_addr;
131-
grub_dprintf("loongson", "args_addr is %p\n", state.gpr[5]);
131+
grub_dprintf("loongson", "args_addr is %p\n", (void *) state.gpr[5]);
132132

133133
if(grub_efi_is_loongson ())
134134
{
@@ -182,7 +182,7 @@ grub_linux_boot (void)
182182
grub_dprintf("loongson", "get old parameter interface\n");
183183
}
184184
state.gpr[6] = (grub_uint64_t)tmp_boot_params;
185-
grub_dprintf("loongson", "boot_params is %p\n", state.gpr[6]);
185+
grub_dprintf("loongson", "boot_params is %p\n", (void *) state.gpr[6]);
186186

187187
mmap_size = find_mmap_size ();
188188
if (! mmap_size)
@@ -210,37 +210,43 @@ grub_linux_boot (void)
210210
{
211211
/* Recovery */
212212
if((lsdesc->type != GRUB_EFI_ACPI_RECLAIM_MEMORY) && \
213-
(lsdesc->type != GRUB_EFI_ACPI_MEMORY_NVS) && \
214-
(lsdesc->type != GRUB_EFI_RUNTIME_SERVICES_DATA) && \
215-
(lsdesc->type != GRUB_EFI_RUNTIME_SERVICES_CODE) && \
216-
(lsdesc->type != GRUB_EFI_RESERVED_MEMORY_TYPE) && \
217-
(lsdesc->type != GRUB_EFI_PAL_CODE))
218-
{
213+
(lsdesc->type != GRUB_EFI_ACPI_MEMORY_NVS) && \
214+
(lsdesc->type != GRUB_EFI_RUNTIME_SERVICES_DATA) && \
215+
(lsdesc->type != GRUB_EFI_RUNTIME_SERVICES_CODE) && \
216+
(lsdesc->type != GRUB_EFI_RESERVED_MEMORY_TYPE) && \
217+
(lsdesc->type != GRUB_EFI_PAL_CODE))
218+
{
219+
220+
free_mem[free_index].memtype = GRUB_EFI_LOONGSON_SYSTEM_RAM_LOW;
221+
free_mem[free_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
222+
free_mem[free_index].memsize = lsdesc->num_pages * 4096;
223+
free_index++;
224+
/*ACPI*/
225+
}
226+
else if(lsdesc->type == GRUB_EFI_ACPI_RECLAIM_MEMORY)
227+
{
228+
acpi_table_mem[acpi_table_index].memtype = GRUB_EFI_LOONGSON_ACPI_TABLE;
229+
acpi_table_mem[acpi_table_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
230+
acpi_table_mem[acpi_table_index].memsize = lsdesc->num_pages * 4096;
231+
acpi_table_index++;
219232

220-
free_mem[free_index].memtype = GRUB_EFI_LOONGSON_SYSTEM_RAM_LOW;
221-
free_mem[free_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
222-
free_mem[free_index].memsize = lsdesc->num_pages * 4096;
223-
free_index++;
224-
/*ACPI*/
225-
}else if((lsdesc->type == GRUB_EFI_ACPI_RECLAIM_MEMORY)){
226-
acpi_table_mem[acpi_table_index].memtype = GRUB_EFI_LOONGSON_ACPI_TABLE;
227-
acpi_table_mem[acpi_table_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
228-
acpi_table_mem[acpi_table_index].memsize = lsdesc->num_pages * 4096;
229-
acpi_table_index++;
230-
231-
}else if((lsdesc->type == GRUB_EFI_ACPI_MEMORY_NVS)){
232-
acpi_nvs_mem[acpi_nvs_index].memtype = GRUB_EFI_LOONGSON_ACPI_NVS;
233-
acpi_nvs_mem[acpi_nvs_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
234-
acpi_nvs_mem[acpi_nvs_index].memsize = lsdesc->num_pages * 4096;
235-
acpi_nvs_index++;
236-
237-
/* Reserve */
238-
}else{
239-
reserve_mem[reserve_index].memtype = GRUB_EFI_LOONGSON_MEMORY_RESERVED;
240-
reserve_mem[reserve_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
241-
reserve_mem[reserve_index].memsize = lsdesc->num_pages * 4096;
242-
reserve_index++;
243-
}
233+
}
234+
else if(lsdesc->type == GRUB_EFI_ACPI_MEMORY_NVS)
235+
{
236+
acpi_nvs_mem[acpi_nvs_index].memtype = GRUB_EFI_LOONGSON_ACPI_NVS;
237+
acpi_nvs_mem[acpi_nvs_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
238+
acpi_nvs_mem[acpi_nvs_index].memsize = lsdesc->num_pages * 4096;
239+
acpi_nvs_index++;
240+
241+
/* Reserve */
242+
}
243+
else
244+
{
245+
reserve_mem[reserve_index].memtype = GRUB_EFI_LOONGSON_MEMORY_RESERVED;
246+
reserve_mem[reserve_index].memstart = (lsdesc->physical_start) & 0xffffffffffff;
247+
reserve_mem[reserve_index].memsize = lsdesc->num_pages * 4096;
248+
reserve_index++;
249+
}
244250
}
245251

246252
/* Recovery sort */
@@ -262,7 +268,7 @@ grub_linux_boot (void)
262268
new_interface_mem->map[tmp_index].memtype = GRUB_EFI_LOONGSON_SYSTEM_RAM_LOW;
263269
new_interface_mem->map[tmp_index].memstart = free_mem[j].memstart;
264270
new_interface_mem->map[tmp_index].memsize = tempMemsize;
265-
grub_dprintf("loongson", "map[%d]:type %x, start 0x%llx, end 0x%llx\n",
271+
grub_dprintf("loongson", "map[%d]:type %x, start 0x%lx, end 0x%lx\n",
266272
tmp_index,
267273
new_interface_mem->map[tmp_index].memtype,
268274
new_interface_mem->map[tmp_index].memstart,
@@ -281,7 +287,7 @@ grub_linux_boot (void)
281287
new_interface_mem->mapcount = tmp_index;
282288
new_interface_mem->header.checksum = 0;
283289

284-
checksum = grub_efi_loongson_grub_calculatechecksum8(new_interface_mem, new_interface_mem->header.length);
290+
checksum = grub_efi_loongson_grub_calculatechecksum8((const grub_uint8_t *) new_interface_mem, new_interface_mem->header.length);
285291
new_interface_mem->header.checksum = checksum;
286292
}
287293
}
@@ -346,10 +352,10 @@ grub_linux_load64 (grub_elf_t elf, const char *filename)
346352

347353
/* Linux's entry point incorrectly contains a virtual address. */
348354
entry_addr = elf->ehdr.ehdr64.e_entry;
349-
grub_dprintf("loongson", "entry address = %p\n", entry_addr);
355+
grub_dprintf("loongson", "entry address = %p\n", (void *) entry_addr);
350356

351357
linux_size = grub_elf64_size (elf, &base, 0);
352-
grub_dprintf("loongson", "base = %p\n", base);
358+
grub_dprintf("loongson", "base = %p\n", (void *) base);
353359

354360
if (linux_size == 0)
355361
return grub_errno;

0 commit comments

Comments
 (0)